Skip to content

Add xonsh shell in dynamic #125

Open

Description

@GouravSardana

We have to make autocomplete feature for dynamic. To make it work we need to create a xonsh shell. Still confused ?
Ref to this - xonsh

How does it actually works?

When a user types dynamic. It will redirect to a different shell on the same terminal and we can use autocomplete in that shell because our normal terminal doesn't allow you to autocomplete.

Ref first 1 sec of GIF [When he type gitsome, Another shell got popup [still confused? Tried installing gitsome in local and type gitsome in terminal]]-

endgoal

Credit for xonsh - xonsh
Credit for Gitsome - Gitsome

Activity

  1. added
    HacktoberfestThis Issue Will be Consider Under Hacktoberfest 2021
    and removed
    hacktoberfest-acceptedGood Work, Your Pull Request is Accepted for the Hacktoberfest
    on Oct 6, 2021
  2. sudojarvis commented on Mar 2, 2022

    @sudojarvis

    Hi, I would like to work on this issue. Could you please give some head start?
    It would be helpful.

  3. GouravSardana commented on Mar 2, 2022

    @GouravSardana
    MemberAuthor

    Go ahead buddy @sudojarvis

  4. sudojarvis commented on Mar 3, 2022

    @sudojarvis

    @GouravSardana gitsome uses xonsh shell. I have to do a similar thing right?

  5. sudojarvis commented on Mar 3, 2022

    @sudojarvis

    Do we have to do it from scratch or we can merge it from xonsh.

  6. GouravSardana commented on Mar 3, 2022

    @GouravSardana
    MemberAuthor

    @sudojarvis That’s correct gitsome uses the xonsh shell.
    no no, you don’t have to create it from scratch just leverage the xonsh and try to replicate the flow from gitsome

  7. sudojarvis commented on Mar 5, 2022

    @sudojarvis

    @GouravSardana could you please assign the issue to me under GSSOC'22.

  8. GouravSardana commented on Mar 5, 2022

    @GouravSardana
    MemberAuthor

    Np. Work on this issue. Don’t worry about assigning the issues. I’ll take care of that

  9. sudojarvis commented on Mar 6, 2022

    @sudojarvis
    Kazam_screencast_00018.mp4

    @GouravSardana Till now it is auto-completing, what I typed previously. But I have used code from gitsome. Is this fine?

  10. GouravSardana commented on Mar 6, 2022

    @GouravSardana
    MemberAuthor

    @sudojarvis Is this using XONSH ? I couldn't see this going to the xonsh terminal just like in gitsome.

    • If I type gitsome, It'll open up a new customize terminal where we can do autocomplete
    • Is this autocomplete based on our history or the argument which we have ?
  11. sudojarvis commented on Mar 6, 2022

    @sudojarvis

    @sudojarvis Is this using XONSH ? I couldn't see this going to the xonsh terminal just like in git

    • If I type gitsome, It'll open up a new customize terminal where we can do autocomplete
    • Is this autocomplete based on our history or the argument which we have ?

    @GouravSardana yes, to 1st two questions. And updated the video watch from 2:35.

  12. sudojarvis commented on Mar 6, 2022

    @sudojarvis
    • Is this autocomplete based on our history or the argument which we have ?
      based on our history
  13. GouravSardana commented on Mar 6, 2022

    @GouravSardana
    MemberAuthor

    Okay but i think this autocomplete should work based on both things. One is history and other is args.
    As of now, can you make a PR, I’ll review it locally and will give you suggestions accordingly

  14. GouravSardana commented on Mar 7, 2022

    @GouravSardana
    MemberAuthor

    @sudojarvis Any update ?

  15. removed their assignment
    on Apr 14, 2022
  16. GouravSardana commented on Oct 21, 2026

    @GouravSardana
    MemberAuthor

    Restart triage: P3 — xonsh shell proposal for this issue (#125). This issue asks for a custom shell to support autocomplete, and the related autocomplete issue #126 explicitly names #125 as a dependency. Current inspected source has no xonsh integration; earlier prototypes do not establish shipped support.

    Next step: agree on command/history completion and normal-shell workflow requirements before adopting the extra runtime surface. Compare the smallest suitable approach and preserve attribution/licensing for reused code. This is outside the first maintenance milestone.

    Source review only; no shell or prototype was run during triage. Keeping this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    HacktoberfestThis Issue Will be Consider Under Hacktoberfest 2021enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions