Skip to content

Patch for Incorporating PR Feedback#74

Merged
egrace479 merged 8 commits intomainfrom
patch/pr-guide-batch-commit
May 5, 2026
Merged

Patch for Incorporating PR Feedback#74
egrace479 merged 8 commits intomainfrom
patch/pr-guide-batch-commit

Conversation

@egrace479
Copy link
Copy Markdown
Member

@egrace479 egrace479 commented May 5, 2026

Addresses points of confusion raised by multiple students in applying PR feedback, in particular, batch committing suggestions. Also clarifies that reviews should be re-requested once comments have been addressed to let reviewer(s) know to look.

This is specifically focused on clarifying the Respond to a PR Review section. Further updates to the earlier sections are still needed to align with GitHub's recent updates, which I included in issue #73, as part of defining updates to the page.

I can't seem to get the caption item to cooperate on smaller text spanning the width of the image without using inline HTML. Any objections to disabling it for that line (as we did in the command line cheat sheet)?

egrace479 added 5 commits May 1, 2026 18:38
Revise structure to more clearly indicate this is part of incorporating feedback
Add more clarity for re-requesting reviews and addressing out-of-scope suggestions
remove ambiguity from statement
@egrace479 egrace479 requested a review from hlapp May 5, 2026 16:56
@hlapp
Copy link
Copy Markdown
Member

hlapp commented May 5, 2026

I can't seem to get the caption item to cooperate on smaller text spanning the width of the image without using inline HTML. Any objections to disabling it for that line (as we did in the command line cheat sheet)?

Not at all.

Copy link
Copy Markdown
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@egrace479 egrace479 merged commit 71dbd7f into main May 5, 2026
1 check passed
@egrace479 egrace479 deleted the patch/pr-guide-batch-commit branch May 5, 2026 22:56
egrace479 added a commit to Imageomics/Imageomics-guide that referenced this pull request May 7, 2026
Pull from Collab Guide [PR 74](Imageomics/Collaborative-distributed-science-guide#74)

* Add more clarification on batch commits for new PR UI

* Add commit message context and pointer

* Update example image with new PR dropdown as example

* Further clarification on commiting suggested changes
Revise structure to more clearly indicate this is part of incorporating feedback
Add more clarity for re-requesting reviews and addressing out-of-scope suggestions

* Clarify re-request review when done with edits,
remove ambiguity from statement

* Add image depicting reviewer side panel for re-requesting review

* Bypass HTML rule to allow for desired formatting for caption
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants