Skip to content

Add admonition to emphasize keeping tokens private and scoped#72

Merged
egrace479 merged 1 commit intomainfrom
feat/token-links
May 5, 2026
Merged

Add admonition to emphasize keeping tokens private and scoped#72
egrace479 merged 1 commit intomainfrom
feat/token-links

Conversation

@egrace479
Copy link
Copy Markdown
Member

Add pointers to GitHub and Hugging Face guidance, clarify generality of remaining page.

This closes Imageomics Guide issue 24, as discussed with @thompsonmj earlier today.

Add pointers to GitHub and Hugging Face guidance, clarify generality of remaining page
@egrace479 egrace479 requested a review from thompsonmj April 30, 2026 22:40
@egrace479 egrace479 added the documentation Improvements or additions to documentation label Apr 30, 2026
@hlapp
Copy link
Copy Markdown
Member

hlapp commented Apr 30, 2026

The change as of now is good, but it doesn't address what I mentioned in response to your question in Imageomics/Imageomics-guide#24.

@hlapp
Copy link
Copy Markdown
Member

hlapp commented Apr 30, 2026

You could of course defer the additional part to a separate issue.

@egrace479
Copy link
Copy Markdown
Member Author

As noted in my reply, I'm in favor of opening a new issue to address workflow permissions, secrets, GitHub Apps, etc. The GitHub documentation left us with some practical application questions for how to actually go about replacing my PAT with a GitHub App (e.g., in the catalog workflow) and I think it's worth providing more clarity on how that actually works (I need to test our setup first).

@egrace479 egrace479 requested a review from hlapp May 5, 2026 17:26
Copy link
Copy Markdown
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@egrace479 egrace479 merged commit ba4baa1 into main May 5, 2026
1 check passed
@egrace479 egrace479 deleted the feat/token-links branch May 5, 2026 22:58
egrace479 added a commit to Imageomics/Imageomics-guide that referenced this pull request May 7, 2026
Pull from Collab Guide [PR 72](Imageomics/Collaborative-distributed-science-guide#72)

Add pointers to GitHub and Hugging Face guidance, clarify generality of remaining page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add guidance on environment variables and tokens

2 participants