Skip to content

fix(build): pass BUN_VERSION build-arg (canary tags were built from latest) - #53

Merged
ImBIOS merged 1 commit into
mainfrom
fix/pass-bun-version-build-arg
Aug 13, 2026
Merged

fix(build): pass BUN_VERSION build-arg (canary tags were built from latest)#53
ImBIOS merged 1 commit into
mainfrom
fix/pass-bun-version-build-arg

Conversation

@ImBIOS

@ImBIOS ImBIOS commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Bug: build_updated.sh never passes --build-arg BUN_VERSION, so the Dockerfile's ARG BUN_VERSION=latest default is used for every build. All canary-* tags (e.g. canary-24.19.0-slim) are therefore identical to latest-* images — bun 1.3.14 — instead of the canary channel.

Fix: pass --build-arg BUN_VERSION=$bun_version. Canary versions (containing -canary) map to the floating canary GitHub release tag, since pinned canary releases (e.g. bun-v1.3.13-canary.20260425.1) are not published on GitHub (404).

Verified: https://github.com/oven-sh/bun/releases/download/canary/bun-linux-x64-baseline.zip → 206 (exists); pinned canary URL → 404.

Summary by CodeRabbit

  • Bug Fixes
    • Improved Docker image builds to use the correct Bun version for both canary and stable releases.
    • Ensured version information is consistently passed to base and Alpine Git images.

…actual canary

Previously --build-arg BUN_VERSION was never passed, so every image
(including canary-* tags) was built with the default 'latest' bun.
Canary versions now map to the floating 'canary' GitHub release tag.
@changeset-bot

changeset-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9ceceff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d96d2e9d-2c15-4a56-8cff-0e88df7461b4

📥 Commits

Reviewing files that changed from the base of the PR and between 5191f98 and 9ceceff.

📒 Files selected for processing (1)
  • build_updated.sh

📝 Walkthrough

Walkthrough

The build loop now selects a BUN_VERSION argument. It maps canary versions to canary and preserves exact versions for other builds. Both standard and Alpine Git Docker builds receive this argument.

Changes

Bun version build configuration

Layer / File(s) Summary
Select and pass Bun version
build_updated.sh
The script maps canary versions to canary, preserves other versions, and passes BUN_VERSION to standard and Alpine Git Docker builds.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to 9cece

This localized build-script change updates version selection for image builds; no actionable merge-blocking risk remains based on the supplied evidence.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: passing the BUN_VERSION build argument to fix incorrect canary image builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pass-bun-version-build-arg

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@ImBIOS
ImBIOS merged commit a601225 into main Aug 13, 2026
7 of 8 checks passed
@ImBIOS
ImBIOS deleted the fix/pass-bun-version-build-arg branch August 13, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant