fix(build): pass BUN_VERSION build-arg (canary tags were built from latest) - #53
Conversation
…actual canary Previously --build-arg BUN_VERSION was never passed, so every image (including canary-* tags) was built with the default 'latest' bun. Canary versions now map to the floating 'canary' GitHub release tag.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe build loop now selects a ChangesBun version build configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to This localized build-script change updates version selection for image builds; no actionable merge-blocking risk remains based on the supplied evidence. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



Bug:
build_updated.shnever passes--build-arg BUN_VERSION, so the Dockerfile'sARG BUN_VERSION=latestdefault is used for every build. Allcanary-*tags (e.g.canary-24.19.0-slim) are therefore identical tolatest-*images — bun 1.3.14 — instead of the canary channel.Fix: pass
--build-arg BUN_VERSION=$bun_version. Canary versions (containing-canary) map to the floatingcanaryGitHub release tag, since pinned canary releases (e.g.bun-v1.3.13-canary.20260425.1) are not published on GitHub (404).Verified:
https://github.com/oven-sh/bun/releases/download/canary/bun-linux-x64-baseline.zip→ 206 (exists); pinned canary URL → 404.Summary by CodeRabbit