Repository navigation
feat(themes): align component themes with schema tokens - #2576
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The locked theming dependency lacks the renamed schema key, causing clean Sass builds to fail, and the inactive case-sensitivity toggle falls below WCAG’s required contrast.
2 open issues
What changed in this PR
This PR aligns component styles with igniteui-theming schema tokens, replacing fixed colors and exposing previously filtered theme values. It coordinates with theming PR #659.
Changes:
- Uses schema tokens for combo case icons, filled input and textarea labels, and disabled rating values.
- Separates dragged-tile overlay styling from resize-placeholder styling.
- Removes obsolete schema-key filtering, including in color-picker themes.
| File | Description |
|---|---|
src/components/tile-manager/themes/shared/tile/tile.common.scss |
Uses the overlay token for dragged tiles. |
src/components/tile-manager/themes/light/_themes.scss |
Preserves light overlay tokens. |
src/components/tile-manager/themes/dark/_themes.scss |
Preserves dark overlay tokens. |
src/components/textarea/themes/shared/textarea.common.scss |
Adds filled-label color rules. |
src/components/textarea/themes/light/_themes.scss |
Preserves the filled-label token. |
src/components/rating/themes/shared/rating.common.scss |
Uses the disabled-value-label token. |
src/components/rating/themes/light/_themes.scss |
Preserves light disabled-value tokens. |
src/components/rating/themes/dark/_themes.scss |
Preserves dark disabled-value tokens. |
src/components/input/themes/shared/input.material.scss |
Adds Material filled-label styling. |
src/components/input/themes/shared/input.indigo.scss |
Adds Indigo filled-label styling. |
src/components/input/themes/shared/input.fluent.scss |
Adds Fluent filled-label styling. |
src/components/input/themes/shared/input.bootstrap.scss |
Adds Bootstrap filled-label styling. |
src/components/input/themes/light/_themes.scss |
Preserves light filled-label tokens. |
src/components/input/themes/dark/_themes.scss |
Preserves dark filled-label tokens. |
src/components/combo/themes/shared/combo.material.scss |
Removes fixed Material case-icon colors. |
src/components/combo/themes/shared/combo.indigo.scss |
Removes fixed Indigo case-icon colors. |
src/components/combo/themes/shared/combo.common.scss |
Centralizes token-based case-icon colors. |
src/components/combo/themes/shared/combo.bootstrap.scss |
Removes the fixed active-icon color. |
src/components/combo/themes/light/_themes.scss |
Preserves light case-icon tokens. |
src/components/combo/themes/dark/_themes.scss |
Preserves dark case-icon tokens. |
src/components/combo/themes/combo.base.scss |
Removes base case-icon color overrides. |
src/components/color-picker/themes/light/_themes.scss |
Removes light schema-key filtering. |
src/components/color-picker/themes/dark/_themes.scss |
Removes dark schema-key filtering. |
Review effort: Balanced
| } | ||
|
|
||
| [part~='case-icon'] { | ||
| color: var-get($theme, 'case-icon-color'); |
simeonoff
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #617
Needs to be tested with the changes from this PR: IgniteUI/igniteui-theming#659
Waiting on
Description
case-icon-colorandcase-icon-color-activeinstead of fixed colors in each themefilled-secondary-colordisabled-value-labeloverlay-background,placeholder-backgroundstays only for the resize ghostType of Change
Testing
The changes needs to be tested manually.
Checklist