Repository navigation
fix(combo): block disabled dropdown interaction - #17975
Open
Xapollon430 wants to merge 1 commit into
Open
Xapollon430 wants to merge 1 commit into
Xapollon430 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17974
Description
Bind the open dropdown contents in Combo and Simple Combo to the control's disabled state using native
inert. Options and other popup controls stop receiving pointer and keyboard input while disabled and become interactive again when re-enabled.Motivation / Context
In Chrome, selecting Orange after the open control became disabled added Orange to the Combo selection and replaced Apple in Simple Combo. Both emitted a model change. With this patch, Apple remains selected and no change fires.
Type of Change
Components affected
Combo and Simple Combo
How Has This Been Tested?
npm teststopped with 7,168 library tests passing and two timeouts, one in an existing Combo Tab test that passed in the focused suite and one in the input mask preset.Test Configuration
Screenshots / Recordings