Repository navigation
fix(time-picker): prevent disabled popup commits - #17973
Open
Xapollon430 wants to merge 1 commit into
Open
Xapollon430 wants to merge 1 commit into
Xapollon430 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17972
Description
Disable the time columns and OK action when the picker is disabled. If the overlay closes while disabled, restore the editor from the committed value instead of applying a pending time. The Cancel action can still dismiss the overlay.
Motivation / Context
In Chrome, clicking hour 11 and then OK in an open dialog after disabling the picker changed 10:30 to 11:30 and emitted one model change. With this patch the same actions leave the value at 10:30 and emit no change.
Type of Change
Components affected
Time Picker
How Has This Been Tested?
npm testrun reported timeouts in unrelated grid filtering tests. The focused Time Picker suite passed.Test Configuration
Screenshots / Recordings
Chrome before and after