Repository navigation
fix(select): block interaction while disabled - #17971
Open
Xapollon430 wants to merge 1 commit into
Open
Xapollon430 wants to merge 1 commit into
Xapollon430 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17970
Description
Bind the open Select dropdown's native
inertproperty to the Select's disabled state. This blocks pointer and keyboard interaction with the overlay, including projected content, while the input is disabled. Re-enabling the Select restores interaction.Motivation / Context
In Chrome, clicking Orange after the open Select became disabled changed the value from Apple to Orange and emitted one
ngModelChangeevent. With this change the same click keeps Apple selected and emits no change.Type of Change
Components affected
Select
How Has This Been Tested?
npm testrun stopped in the library suite with 7,167 passing tests and two timeouts in grid filtering-row keyboard focus and the input mask preset. The focused Select suite passed.Test Configuration
Screenshots / Recordings
Chrome before and after