Skip to content

fix(grid): avoid double detach on destroy with adv. filtering open - … #17966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivanvpetrov wants to merge 2 commits into
base: 22.2.x
Choose a base branch
from
Open

fix(grid): avoid double detach on destroy with adv. filtering open - … #17966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43cff81
fix(grid): avoid double detach on destroy with adv. filtering open - …
ivanvpetrov Nov 12, 2026
0042903
Merge branch '22.2.x' into ipetrov/fix-17962-22.2
ivanvpetrov Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions projects/igniteui-angular/grids/grid/src/grid-base.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4322,10 +4322,12 @@ export abstract class IgxGridBaseDirective implements GridType,

this.textHighlightService.destroyGroup(this.id);

if (this._advancedFilteringOverlayId) {
// The overlay service detaches the dialog on its own when Angular destroys it, which happens
// before this hook because the dialog is created in the grid's view container.
if (this._advancedFilteringOverlayId && this.overlayService.getOverlayById(this._advancedFilteringOverlayId)) {
this.overlayService.detach(this._advancedFilteringOverlayId);
this._advancedFilteringOverlayId = '';
}
this._advancedFilteringOverlayId = '';

this.overlayIDs.forEach(overlayID => {
const overlay = this.overlayService.getOverlayById(overlayID);
Expand Down
39 changes: 37 additions & 2 deletions projects/igniteui-angular/grids/grid/src/grid-filtering-advanced.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ import { SampleTestData } from '../../../test-utils/sample-test-data.spec';
import { By } from '@angular/platform-browser';
import { IgxHGridRemoteOnDemandComponent, IgxHierarchicalGridMissingChildDataComponent } from '../../hierarchical-grid/src/hierarchical-grid.spec';
import { QueryBuilderFunctions } from '../../../query-builder/src/query-builder/query-builder-functions.spec';
import { IFilteringEventArgs, IgxGridNavigationService, IgxGridToolbarAdvancedFilteringComponent } from 'igniteui-angular/grids/core';
import { IFilteringEventArgs, IgxColumnComponent, IgxGridNavigationService, IgxGridToolbarAdvancedFilteringComponent } from 'igniteui-angular/grids/core';
import { FilteringExpressionsTree, FilteringLogic, FormattedValuesFilteringStrategy, IGridResourceStrings, IgxNumberFilteringOperand, IgxStringFilteringOperand } from 'igniteui-angular/core';
import { QueryBuilderSelectors } from 'igniteui-angular/query-builder/src/query-builder/query-builder.common';
import { IgxDateTimeEditorDirective } from 'igniteui-angular/directives';
import { IgxHierarchicalGridComponent } from 'igniteui-angular/grids/hierarchical-grid';
import { Component, signal, viewChild } from '@angular/core';

describe('IgxGrid - Advanced Filtering #grid - ', () => {
beforeEach(waitForAsync(() => {
Expand All @@ -37,7 +38,8 @@ describe('IgxGrid - Advanced Filtering #grid - ', () => {
IgxGridAdvancedFilteringWithToolbarComponent,
IgxHierarchicalGridTestBaseComponent,
IgxHierarchicalGridExportComponent,
IgxHGridRemoteOnDemandComponent
IgxHGridRemoteOnDemandComponent,
IgxGridAdvancedFilteringConditionalComponent
],
providers: [
IgxGridNavigationService
Expand Down Expand Up @@ -75,6 +77,24 @@ describe('IgxGrid - Advanced Filtering #grid - ', () => {
expect(advFilterButton !== null && advFilterButton !== undefined).toBe(true, 'Adv.Filter button is not visible.');
}));

it('Should not warn about a wrong overlay id when the grid is destroyed while the dialog is opened - issue #17962', fakeAsync(() => {
const conditionalFix = TestBed.createComponent(IgxGridAdvancedFilteringConditionalComponent);
conditionalFix.detectChanges();

conditionalFix.componentInstance.grid().openAdvancedFilteringDialog();
conditionalFix.detectChanges();
tick(200);
expect(document.querySelector('.igx-advanced-filter')).not.toBeNull();

conditionalFix.componentInstance.showGrid.set(false);
conditionalFix.detectChanges();
tick(200);

expect(conditionalFix.componentInstance.grid()).toBeUndefined();
expect(document.querySelector('.igx-advanced-filter')).toBeNull();
expect(console.warn).not.toHaveBeenCalledWith('igxOverlay.detach was called with wrong id: ', jasmine.anything());
}));

it('Should correctly initialize the Advanced Filtering dialog.', fakeAsync(() => {
// Open Advanced Filtering dialog.
grid.openAdvancedFilteringDialog();
Expand Down Expand Up @@ -1920,3 +1940,18 @@ const verifyElementIsInExpressionsContainerView = (fix, element: HTMLElement) =>
expect(elementRect.left >= exprContainerRect.left).toBe(true, 'left is not in view');
expect(elementRect.right <= exprContainerRect.right).toBe(true, 'right is not in view');
};

@Component({
template: `
@if (showGrid()) {
<igx-grid [data]="data" height="500px">
<igx-column field="ProductName" dataType="string"></igx-column>
</igx-grid>
}`,
imports: [IgxGridComponent, IgxColumnComponent]
})
class IgxGridAdvancedFilteringConditionalComponent {
public grid = viewChild(IgxGridComponent);
public showGrid = signal(true);
public data = SampleTestData.excelFilteringData();
}
Loading