Repository navigation
feat(themes): align component themes with schema tokens - #17925
Merged
Merged
Conversation
adrianptrv
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new combo schema-key lookup is incompatible with the locked igniteui-theming 30.1.0 dependency, causing Sass compilation to fail.
1 open issue
What changed in this PR
Aligns Chip, Combo, Input Group, and Rating styles with their schema tokens, coordinated with the linked igniteui-theming changes.
Changes:
- Uses dedicated tokens for chip ghost text and combo case-sensitive icons.
- Applies separate colors to filled input labels and disabled rating value labels.
| File | Description |
|---|---|
projects/igniteui-angular/input-group/src/input-group/themes/_base.scss |
Uses filled-secondary-color for filled-state labels. |
projects/igniteui-angular/core/src/core/styles/components/rating/_rating-theme.scss |
Uses disabled-value-label for disabled value labels. |
projects/igniteui-angular/combo/src/combo/themes/_base.scss |
Replaces fixed case-icon colors with schema tokens. |
projects/igniteui-angular/chips/src/chips/themes/_base.scss |
Uses ghost-text-color for drag ghost text. |
Review effort: Balanced
desig9stein
added
💥 status: in-test
desig9stein
added
✅ status: verified
simeonoff
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #617
Needs to be tested with the changes from this PR: IgniteUI/igniteui-theming#659
Waiting on
Description
ghost-text-colorinstead offocus-text-colorcase-icon-colorandcase-icon-color-activeinstead of fixed colorsdisabled-value-labelfilled-secondary-colorType of Change:
Component(s) / Area(s) Affected:
Chip, Combo, Input Group, Rating
How Has This Been Tested?
Checklist: