Repository navigation
fix(forms): prevent implicit form submission from grid - 21.2.x - #17743
Open
igdmdimitrov wants to merge 3 commits into
Open
igdmdimitrov wants to merge 3 commits into
igdmdimitrov wants to merge 3 commits into
Conversation
igdmdimitrov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix addresses the reported issue with regression coverage and no identified blockers; tests were not executed during review.
Review effort: Balanced
Findings: None
What changed in this PR
Addresses #17638 by preventing the snackbar’s default action button from acting as a form submit button.
Changes:
- Adds
type="button"to the default action button. - Adds a regression assertion for the button type.
- Documents the fix in the changelog.
| File | Description |
|---|---|
| projects/igniteui-angular/snackbar/src/snackbar/snackbar.component.spec.ts | Verifies the explicit button type. |
| projects/igniteui-angular/snackbar/src/snackbar/snackbar.component.html | Sets the action button’s non-submit type. |
| CHANGELOG.md | Records the form-submission fix. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
igdmdimitrov
changed the title
igdmdimitrov
added
🛠️ status: in-development
igdmdimitrov
changed the title
igdmdimitrov
added
❌ status: awaiting-test
mddragnev
added
✅ status: verified
viktorkombov
approved these changes
Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17638
Approach: a single internal helper,
preventImplicitSubmission(igniteui-angular/core), cancels Enter only on inputs that belong to a form and would submit it (not button, submit, reset, image, file or color inputs). It reads the focused element throughevent.composedPath(), so elements inside shadow DOM are handled correctly. It runs on keydown and keypress, in the capture phase on the grid host. keypress is needed because a date picker that selects a day on Enter moves focus back to its input before the browser submits.Used by:
IgxGridBaseDirective(so it covers the tree, hierarchical and pivot grids too; the spec only exercises IgxGrid),igx-column-actions,igx-pivot-data-selectorandigx-query-builder. The query builder covers the advanced filtering dialog, including when it's standalone or opened with custom overlay settings. The snackbar and the query builder buttons now havetype="button".Type of Change (check all that apply):
How Has This Been Tested?
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)