Repository navigation
feat(tabs): add header position sample - #4071
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
viktorkombov
requested review from
teodosiah
and
a balanced review from Copilot
November 5, 2026 16:53
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review identifies no active issues with the Tabs header-position documentation sample.
No open issues 🎉
What changed in this PR
Adds a Tabs header-position sample for the documentation, demonstrating top, start, and end placement with an interactive selector.
Changes:
- Adds the sample component, template, and layout styles.
- Registers the sample route and navigation metadata.
- Includes the sample in the live-editing configuration.
| File | Description |
|---|---|
src/app/layouts/tabs/tabs-header-position/tabs-header-position.component.ts |
Defines position options and sample tab content. |
src/app/layouts/tabs/tabs-header-position/tabs-header-position.component.scss |
Styles the sample layout and tab content. |
src/app/layouts/tabs/tabs-header-position/tabs-header-position.component.html |
Connects the position selector to the tabs. |
src/app/layouts/layouts.routes.ts |
Registers the header-position sample route. |
src/app/layouts/layouts-routes-data.ts |
Adds the sample’s navigation label. |
live-editing/configs/TabsConfigGenerator.ts |
Registers the sample for live editing. |
Review effort: Balanced
teodosiah
previously approved these changes
Nov 9, 2026
11 of 16 tasks
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ChronosSF
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4070
Adds the
tabs-header-positionsample for the Tabs docs (IgniteUI/igniteui-documentation#1016). Based on #4069 for igniteui-angular 22.3.0-beta.1.🤖 Generated with Claude Code