Repository navigation
feat(chip): show Indigo icons in the Indigo theme - #4057
Merged
Merged
Conversation
Hristo313
added
status: in-test
status: verified
and removed
status: awaiting-test
status: in-test
labels
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the theme-aware sample icon changes.
No open issues 🎉
What changed in this PR
This PR adds theme-aware sample icons so the chip sample can display the Indigo arrow icon when the Indigo theme is active.
Changes:
- Adds a service that maps
arrow_upwardto its Indigo variant and restores the default icon for other themes. - Initializes icon synchronization alongside the application’s theme service and cleans up the subscription on destruction.
| File | Description |
|---|---|
src/app/services/sample-icons.service.ts |
Adds theme-dependent icon mapping and subscription cleanup. |
src/app/app.component.ts |
Initializes the sample icon service after theme initialization. |
Review effort: Balanced
kdinev
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IgniteUI/igniteui-documentation#937