Repository navigation
Introduce DisplayFormElement for embedding HTML in CompatForm - #385
Merged
Merged
Conversation
jrauh01
force-pushed
the
feature/display-form-element
branch
2 times, most recently
from
May 27, 2026 13:28
0164031 to
af8b156
Compare
Merged
jrauh01
force-pushed
the
feature/display-form-element
branch
from
June 10, 2026 05:49
af8b156 to
cff9642
Compare
TheSyscall
requested changes
Jun 23, 2026
Contributor
Author
|
As the accessibility features are not yet very well developed in the IPL and we don't want to implement a half-baked solution, but rather think of it more carefully, I did not add it for now. |
Allows arbitrary `ValidHtml` content to be placed inside a `CompatForm` control group, complete with an optional label and description icon. The companion CSS rule ensures the wrapper div stretches to fill available horizontal space within the flex layout.
The previous falsy check treated a description of `0` as absent, suppressing the info icon even though a non-null value was set.
When content implements `HtmlElementInterface`, the info icon is now linked to the content element via `aria-describedby`, so screen readers announce the description when the element receives focus. The icon itself gains `aria-hidden="true"` and `role="img"` to prevent it from being read out twice. If the content element has no `id`, one is generated and set automatically.
The accessibility features in the IPL are not yet very well developed. We don't want to implement a half-baked solution, but rather think of it more carefully. This reverts commit ae30033.
jrauh01
force-pushed
the
feature/display-form-element
branch
from
June 25, 2026 07:23
7b1d3ff to
01f0d42
Compare
TheSyscall
requested changes
Jun 25, 2026
Co-authored-by: Alexander Rieß <alexander.riess@icinga.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows arbitrary
ValidHtmlcontent to be placed inside aCompatFormcontrol group, complete with an optional label and description icon. The companion CSS rule ensures the wrapper div stretches to fill available horizontal space within the flex layout.This is used for the new two-factor auth feature in Icinga Web.