Repository navigation
feat: sort service cube details by severity (#144) - #177
Open
DanielVdWP wants to merge 4 commits into
Open
DanielVdWP wants to merge 4 commits into
DanielVdWP wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #144.
Service cube detail links currently open the Icinga DB service
list without explicitly setting the sort order.
As a result, services contributing to the cube's problem state
may not appear at the top of the list.
This change makes the service details view sort by severity
in descending order by default.
Changes
Testing
The regression was reproduced against the original implementation
using GitHub Actions with PHP 8.3 and PHP 8.4.
Both environments reproduced the missing severity sort parameter.
After applying the fix, the same tests passed on both PHP versions.
Additional checks verify that existing filters, dimensions,
cube slices and legacy IDO behavior remain unchanged.
Regression tests use the actual production widget classes with
lightweight dependency stubs. Full Icinga Web integration testing
has not been performed.
CI results
Bug reproduction:
https://github.com/DanielVdWP/icingaweb2-module-cube/actions/runs/35562301760
Fix validation:
https://github.com/DanielVdWP/icingaweb2-module-cube/actions/runs/35562324845