Repository navigation
fix: preserve zero values in cube dimension labels (#172) - #176
Open
DanielVdWP wants to merge 2 commits into
Open
DanielVdWP wants to merge 2 commits into
DanielVdWP wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #172.
Cube dimension labels currently display an underscore (
_) when acustom variable contains the numeric value
0or the string"0".This happens because the dimension label renderer uses PHP's shorthand
ternary operator (
?:), which treats zero values as falsy.Changes
_for null, empty string, and false values.and service cubes.
Testing
The following cases were verified locally using PHP 8.4:
0.0.0._._._.The regression was reproduced against the original implementation.
PHP syntax validation passed.
GitHub Actions CI will run when the pull request is opened.