Repository navigation
go-license: Generic Go License Check - #35
Conversation
Extract our Go License Check action used in Icinga DB, Notifications, K8s, and the Go Library into a reusable action.
|
Hopping in with a quick question: you're leaving the list of allowed licenses within the individual projects and there's already some divergence there. We need a distinction whether our repo is MIT or GPL licensed, but say for all GPLv3+ repos, the list of allowed licenses should be identical. Have you considered specifying a target license as an input (i.e. all licenses used should be compatible with that) and selecting a preset of allowed licenses from that? |
|
Just in time 🙃 I thought about detecting the current license from the |
|
At least Icinga DB and Icinga Notifications both are |
|
Fair enough; I will create a follow up PR to generalize this :) |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
Drop the "allowed_licenses" input and decide based on the project's main license. The current allow lists are copied from our repositories. --- References #35 (comment) Checked downstream: - Icinga/icingadb#1233 - Icinga/icinga-notifications#603 - Icinga/icinga-go-library#279 - Icinga/icinga-kubernetes#290
Extract our Go License Check action used in Icinga DB, Notifications, K8s, and the Go Library into a reusable action.
Successfully tested this in our downstream repos:
https://github.com/Icinga/icingadb/actions/runs/41802940955/job/126484702753?pr=1233
https://github.com/Icinga/icinga-notifications/actions/runs/41803761723/job/126485632755?pr=603
https://github.com/Icinga/icinga-go-library/actions/runs/41803951777/job/126486250324?pr=279
https://github.com/Icinga/icinga-kubernetes/actions/runs/41804352432/job/126487558208?pr=290