Add explicit permissions blocks to caller workflow files#176
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 78.68% 78.68%
=======================================
Files 12 12
Lines 793 793
=======================================
Hits 624 624
Misses 169 169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit
permissions:blocks to the workflow files that call ITensorActions reusable workflows.Most of these files previously declared no
permissions:block and inherited theirGITHUB_TOKENceiling from the repository / organization Actions defaults. After this change, each workflow's permissions live in the YAML rather than in a settings page, and any future change to the org or per-repo Actions default can only narrow (never widen) what these workflows can do.Each block declares the minimum the workflow actually needs (
contents: readfor checkout-only workflows; elevated for Documentation gh-pages deploy, TagBot tag creation, IntegrationTest's gate job, and VersionCheck's PR-file lookup).Verified by temporarily flipping this repo's per-repo Actions setting to
default_workflow_permissions: readandcan_approve_pull_request_reviews: false— the planned org-default end state. All workflows pass.