Repository navigation
Console: fix dialog/select overflow; audit opens every overlay - #51
Merged
Merged
Conversation
The Invite dialog's role select grew past the dialog when Admin or Operator was chosen: option descriptions were part of the selected value. Select items take a description shown only in the open list; triggers never exceed their container and truncate with an ellipsis; dialog children can shrink. Also fixed: clipped placeholders and a scrolling header in Create API key, stretched sparkline end dots, invalid ARIA in the command palette list, an unnamed Activity popover, truncated stat-card text on phones. audit:ui now opens every dialog, select (trying each option), menu, popover and the command palette, checks containment and clipped text and placeholders, waits for animations before axe, and takes --only <regex>. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177yERMgobFkKXuZUcZmpwZ
#e66767 on its 20% tint measured 4.06:1; #f08a85 is about 5.0:1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177yERMgobFkKXuZUcZmpwZ
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Invite dialog's role select grew past the dialog when Admin or Operator was chosen. The earlier audit missed it: it only checked page-level overflow and never opened dialogs or changed a select's value. This PR fixes that class of bug at the component level and makes the audit catch it.
Fixes
descriptionshown only in the open list (not mirrored into the trigger); triggers never exceed their container and truncate with an ellipsis (a flex value had disabledline-clamp). The Invite dialog shows the chosen role's description under the field.*:min-w-0), height capped to the viewport with scrolling.role=separatorchild (invalid in a listbox); Activity popover had no accessible name; dark-mode destructive buttons were 4.06:1 (now about 5:1).Audit (
npm run audit:ui)Now opens every dialog, select (choosing each option in turn), menu, popover and the command palette, in light, dark and mobile; checks containment, clipped text and placeholders; waits for animations before axe;
--only <regex>filters routes. Run against the pre-fix code it reproduces the bug (content 57 px wider than the dialog with Admin, 83 px on mobile).Checklist
npm run audit:ui: gateway 54 and cloud 45 page views, no problemsdocs/CONSOLE.md(UI quality bar),CHANGELOG.mdGenerated by Claude Code