Test 46999: Extract Offline Message Box Handler#11452
Open
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_11from
Open
Test 46999: Extract Offline Message Box Handler#11452matheuszych wants to merge 1 commit intoILIAS-eLearning:release_11from
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_11from
Conversation
See: https://mantis.ilias.de/view.php?id=46999 The offline test info message and optional settings link were inlined in `testScreen()`. Moved the logic to `handleOfflineMessageBox()` for clarity and used an early return when the user lacks write permission.
matheuszych
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=46999
The offline test info message and optional settings link were inlined in
testScreen(). Moved the logic tohandleOfflineMessageBox()for clarity and used an early return when the user lacks write permission./cc @thojou