Variability: Do not overwrite feature attribute assignments if not necessary - #1931
Open
kbirken wants to merge 4 commits into
Open
Variability: Do not overwrite feature attribute assignments if not necessary#1931kbirken wants to merge 4 commits into
kbirken wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the solver runs on a configuration, compulsory attribute values are set if the value is mandatory. If the solver computes the previous value again, the value expression has been replaced. This has a couple of drawbacks, as the node identity of the value (e.g. a
NumberLiteral) will be changed although the semantic value stays the same.The PR adds a test which reproduces the problem and introduces the fix. It also does some API changes necessary for solving the companion PR in IETS3/iets3.core#1781.
Additionally, the helper classes
AssignmentValueMapandAssignmentValueListhave been introduced to make the new code more readable and also refactor the existing code.CHANGELOG has been updated.
Note: The API for iets3.core has been changed. So iets3.core has to be adapted to use this version of iets3.opensource. See also the companion PR in IETS3/iets3.core#1781.
TODO: I keep separate commits to make the review easier. Do not merge from maintenance/mps20241, instead squash the commits after the review.
This solves #1921.