Skip to content

chore(all): Replace exceljs with write-excel-file #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tombrunet merged 12 commits into from
Sep 1, 2026
Merged

chore(all): Replace exceljs with write-excel-file #2628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ef66c56
chore(all): Replace exceljs due to lack of maintenance
tombrunet Aug 28, 2026
826be74
exceljs error
tombrunet Aug 28, 2026
90425fc
Fix colors / tables
tombrunet Aug 31, 2026
5c5e2cb
Fix cypress error
tombrunet Aug 31, 2026
32f61c1
fix test
tombrunet Aug 31, 2026
e0a39a1
test(xlsx): add XLSX reporter tests for mocha, vitest/node, and cypress
tombrunet Aug 31, 2026
8cf5d12
fix(xlsx): guard division by zero in Scan summary % columns
tombrunet Aug 31, 2026
dcab339
fix(ci): install write-excel-file before cypress run; guard adm-zip o…
tombrunet Aug 31, 2026
076dc4b
fix(vitest): exclude node-only XLSX test from browser vitest config
tombrunet Aug 31, 2026
9870259
fix(deps): move write-excel-file from peerDeps to deps in all checker…
tombrunet Aug 31, 2026
54f4f35
fix(deps): move write-excel-file to regular deps everywhere; update R…
tombrunet Aug 31, 2026
8069925
Move adm-zip to dep
tombrunet Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ jobs:
working-directory: rule-server
- run: npm run build
working-directory: rule-server
- run: sed -i'.old' -e "s/[\"|']use strict[\"|']//g" ./exceljs.js
working-directory: accessibility-checker-extension/node_modules/exceljs/dist
- run: sed -i'.old' -e "s/[\"|']use strict[\"|']//g" ./exceljs.min.js
working-directory: accessibility-checker-extension/node_modules/exceljs/dist
- run: cp -f ./manifest_Chrome.json ./src/manifest.json
working-directory: accessibility-checker-extension
- run: npm run package:browser
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,6 @@ jobs:
working-directory: rule-server
- run: npm run build
working-directory: rule-server
- run: sed -i'.old' -e "s/[\"|']use strict[\"|']//g" ./exceljs.js
working-directory: accessibility-checker-extension/node_modules/exceljs/dist
- run: sed -i'.old' -e "s/[\"|']use strict[\"|']//g" ./exceljs.min.js
working-directory: accessibility-checker-extension/node_modules/exceljs/dist
- run: cp -f ./manifest_Chrome.json ./src/manifest.json
working-directory: accessibility-checker-extension
- run: |
Expand Down Expand Up @@ -239,7 +235,6 @@ jobs:
else
EXT_VERSION="${NPM_VERSION}.9999"
fi;
sed -i'.old' -e 's/"version": "3.0.0",/"version": "'"${EXT_VERSION}"'",/g' ./manifest.json
fi;
working-directory: accessibility-checker-extension/src
- run: rm manifest.json.old
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,9 @@ jobs:
working-directory: accessibility-checker
- run: npx mocha -R dot test/mocha/aChecker.Fast/aChecker.Scans/aChecker.Content.Puppeteer.test.mjs
working-directory: accessibility-checker

- run: npx mocha --timeout 30000 -R dot test/mocha/aChecker.Fast/aChecker.Scans/aChecker.XLSX.test.mjs
working-directory: accessibility-checker

###############################################################################
# Node basic test
####
Expand Down Expand Up @@ -195,6 +197,8 @@ jobs:
working-directory: accessibility-checker
- run: npx mocha -R dot test/mocha/aChecker.Fast/aChecker.Scans/aChecker.Content.Puppeteer.test.mjs
working-directory: accessibility-checker
- run: npx mocha --timeout 30000 -R dot test/mocha/aChecker.Fast/aChecker.Scans/aChecker.XLSX.test.mjs
working-directory: accessibility-checker

###############################################################################
# Node basic test
Expand Down Expand Up @@ -555,6 +559,8 @@ jobs:
working-directory: vitest-accessibility-checker
- run: npx vitest run
working-directory: vitest-accessibility-checker/test
- run: npm run test:node
working-directory: vitest-accessibility-checker

###############################################################################
# Extension Build verification and test
Expand Down Expand Up @@ -591,10 +597,6 @@ jobs:
npm install
npm run build
working-directory: rule-server
- run: sed -i'.old' -e "s/[\"|']use strict[\"|']//g" ./exceljs.js
working-directory: accessibility-checker-extension/node_modules/exceljs/dist
- run: sed -i'.old' -e "s/[\"|']use strict[\"|']//g" ./exceljs.min.js
working-directory: accessibility-checker-extension/node_modules/exceljs/dist
- run: cp -f ./manifest_Chrome.json ./src/manifest.json
working-directory: accessibility-checker-extension
- run: npm run package:browser
Expand Down
1 change: 0 additions & 1 deletion accessibility-checker-extension/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ module.exports = {
"testTimeout": 60000,
"moduleNameMapper": {
// Force module uuid to resolve with the CJS entry point, because Jest does not support package.json.exports. See https://github.com/uuidjs/uuid/issues/451
// Note that this comes through the exceljs module
"uuid": require.resolve('uuid'),
"\\.(css|less|scss|sass)$": "identity-obj-proxy"
},
Expand Down
Loading
Loading