Restore SSE legacy + update tests + docs after PR #83#85
Merged
Conversation
Mount legacy SSE transport at /mcp-sse alongside the Streamable HTTP transport at /mcp. Mirrors the seller's pattern; keeps older MCP clients working without breaking the current standard endpoint. bead: ar-5xcx Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Rename TestSSEMounting → TestMCPMounting - test_mount_mcp_adds_route: assert both /mcp and /mcp-sse present - test_buyer_api_app_has_mcp_mounted: same dual-transport assertions - test_settings_default_cors_origins: accept wildcard (correct for MCP server) - test_app_cors_middleware_uses_settings: allow wildcard, check credentials=False bead: ar-5xcx Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
New tests/unit/test_mcp_streamable_http.py: - TestMCPRoutePresence: verifies both /mcp and /mcp-sse are mounted - test_streamable_http_initialize_handshake: POSTs initialize payload to /mcp via ASGI in-process transport, asserts 200 + MCP fields bead: ar-5xcx Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All buyer-inbound doc URLs updated from /mcp/sse/sse → /mcp (Streamable HTTP). Legacy SSE fallback noted as /mcp-sse/sse for older clients. Files changed: - docs/claude-desktop-setup.md - docs/multi-client-setup.md - docs/architecture/mcp-server.md (mounting section + diagram) - docs/ai-assistant/developer-setup.md bead: ar-5xcx Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Three seller-outbound endpoint references corrected: - Buyer→seller MCP connectivity description: /mcp/sse → /mcp-sse/sse (line 708) - MCP SSE troubleshooting check 4: /mcp/sse → /mcp-sse/sse (line 974) - MCP client troubleshooting check 2: /mcp/sse → /mcp-sse/sse (line 1022) Also updates buyer-inbound MCP doc URLs in the same file: - Overview endpoint: /mcp/sse/sse → /mcp (Streamable HTTP) - Claude Desktop config: /mcp/sse/sse → /mcp - Streamable HTTP client example: /mcp/sse/sse → /mcp bead: ar-u3ox Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #83 which added Streamable HTTP transport at /mcp and removed SSE entirely. Three small follow-ups:
/mcp-sse/sseso older clients aren't broken (mirrors seller's pattern)TestSSEMounting→TestMCPMounting, CORS default test)/mcpas canonical (with/mcp-sse/ssedocumented as legacy fallback)/mcp/sse→/mcp-sse/ssecorrections indeployment-ops-guide.md(seller's outbound endpoint references)What's in
Test posture
POST /mcp/negotiates protocol (returnsprotocolVersion,serverInfo,capabilities);GET /mcp-sse/sseopens SSE event stream — both transports confirmed workingTest plan
/mcp(Streamable HTTP) — should work/mcp-sse/sse— should work🤖 Generated with Claude Code