Skip to content

Fix proto/generated-code drift breaking gRPC reflection and samples #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garvitkaushik-123 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix proto/generated-code drift breaking gRPC reflection and samples #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ Containers must include an `agent-manifest` label in image metadata with:

The protobuf imports OpenRTB v2.6 definitions:
```protobuf
import "com/iabtechlab/openrtb/v2.6/openrtb.proto";
import "com/iabtechlab/openrtb/v2/openrtb.proto";
```

You'll need the IAB Tech Lab OpenRTB protobuf definitions from:
Expand Down
11 changes: 1 addition & 10 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,7 @@ build-all: build build-rust
# Protobuf targets

bindings:
for x in ${LANGUAGES}; do \
protoc --proto_path=. \
--$${x}_out=. \
--experimental_editions \
openrtb.proto agenticrtbframework.proto; \
protoc --proto_path=. \
--$${x}_out=. \
--$${x}-grpc_out=require_unimplemented_servers=false:. \
agenticrtbframeworkservices.proto; \
done
scripts/generate.sh

check:
prototool lint
Expand Down
Loading