Repository navigation
fix: classify a webhook reset on the error cause and retry a resolver failure (#896) - #907
Merged
Merged
Conversation
HugoXK-bot
approved these changes
Nov 16, 2026
HugoXK-bot
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: PASS at 8d51598
Written-by: HugoXK-bot
Ran:
npx tsx --test test/notificationOutbox.test.ts test/webhookSsrf.test.ts— 21/21 passnpm run lint— pass (11 baselined warnings)npm run typecheck— passnpm run build— passnpm test— 2304/2306 pass; the two failures are pre-existing environment failures (test/gateBaseTree.test.ts,test/nginxCheck.test.ts) that also fail on a cleanorigin/mainnode scripts/risk-gate.mjs --base origin/main—risk-tier: T2
Not run:
- A live webhook endpoint or real DNS; the transports are driven by injected fetch/resolver.
- GitHub Actions (the PR runs CI).
HugoXK-bot
approved these changes
Nov 16, 2026
HugoXK-bot
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: PASS at ef59785
Written-by: HugoXK-bot
Ran:
npx tsx --test test/notificationOutbox.test.ts test/webhookSsrf.test.ts— 21/21 passnpm run lint— pass (11 baselined warnings)npm run typecheck— passnpm run build— passnpm test— 2304/2306 pass; the two failures are pre-existing environment failures (test/gateBaseTree.test.ts,test/nginxCheck.test.ts) that also fail on a cleanorigin/mainnode scripts/risk-gate.mjs --base origin/main—risk-tier: T2
Not run:
- A live webhook endpoint or real DNS; the transports are driven by injected fetch/resolver.
- GitHub Actions (the PR runs CI).
HugoXK-bot
approved these changes
Nov 16, 2026
HugoXK-bot
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: PASS at 8974d00
Written-by: HugoXK-bot
Ran:
npx tsx --test test/notificationOutbox.test.ts test/webhookSsrf.test.ts— 21/21 passnpm run lint— pass (11 baselined warnings)npm run typecheck— passnpm run build— passnpm test— 2304/2306 pass; the two failures are pre-existing environment failures (test/gateBaseTree.test.ts,test/nginxCheck.test.ts) that also fail on a cleanorigin/mainnode scripts/risk-gate.mjs --base origin/main—risk-tier: T2
Not run:
- A live webhook endpoint or real DNS; the transports are driven by injected fetch/resolver.
- GitHub Actions (the PR runs CI).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: HugoXK
Fixes #896
What changed:
isAmbiguousWebhookFailure()readserror.cause.codeas well aserror.code, so Undici'sECONNRESET/EPIPE/UND_ERR_SOCKETon the cause isunknownand is not replayed automatically.assertSafeWebhookUrlnow throwsWebhookAddressErrorwith a kind: policy refusals (scheme, credentials, allowlist, private or reserved address) areblocked; a resolver failure (the resolver throws or returns no address) isretry.postWebhookuses that kind; the old catch-allblockedis gone.ECONNRESETisunknownand is not claimed on the next pass; a resolverEAI_AGAINisretry; a private resolved address staysblocked.docs/security.mdstates the distinction.Ran:
npx tsx --test test/notificationOutbox.test.ts test/webhookSsrf.test.ts— 21/21 passnpm run lint— pass (11 baselined warnings)npm run typecheck— passnpm run build— passnpm test— 2304/2306 pass; the two failures are pre-existing environment failures (test/gateBaseTree.test.ts,test/nginxCheck.test.ts) that also fail on a cleanorigin/mainnode scripts/risk-gate.mjs --base origin/main—risk-tier: T2node scripts/version.mjs check— oknpm run secret:scan— cleannode scripts/changelog.mjs check— 9 fragments okNot run:
Risk: T2 (
src/lib/webhook.ts); a PASS at the tip is required.