feat: register_device tags + preserve tags on rename (HUB-6087) - #51
Merged
Conversation
4 tasks
4 tasks
buckleypaul
approved these changes
Aug 25, 2026
Allow custom tags at registration time for FTUE satellite boards, and omit empty set_tags on name-only updates so those tags are not replaced. Co-authored-by: Cursor <cursoragent@cursor.com>
danielr-hubblenetwork
force-pushed
the
hub-6087-sat-tags
branch
from
August 25, 2026 18:53
395fa10 to
b601bad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tagstoOrganization.register_device/cloud.register_device, sent as the Cloud API’s per-device tags list (tags: [{...}]).set_tags: {}on name-onlyupdate_device/set_device_name.set_tagsis a full replace; the empty map was wiping tags applied at registration (needed for satellite FTUE).Enables hubble-tldm to register
*_satboards withsatellite: next-pass(HUB-6087).Merge / release notes
tags=for_satboards.Test plan
pytest tests/test_register_device_cloud.py tests/test_register_device_validation.pytags={"satellite": "next-pass"}, thenset_device_name, and confirm tags remain on GET deviceMade with Cursor