Skip to content

ci: update CI trigger to include path that affects each CI tests - #326

Open
HongNguyen635 wants to merge 1 commit into
HubbleNetwork:mainfrom
HongNguyen635:ci/update-ci-trigger
Open

ci: update CI trigger to include path that affects each CI tests#326
HongNguyen635 wants to merge 1 commit into
HubbleNetwork:mainfrom
HongNguyen635:ci/update-ci-trigger

Conversation

@HongNguyen635

Copy link
Copy Markdown
Collaborator

Update the CI build for each port to include paths to source code that would benefit from a CI rebuild to check for issues.

paths:
- "include/**"
- "port/esp-idf/**"
- "port/freertos/**"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is gating on freertos port changes intentional?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah ESP-IDF is Espressif-flavored of FreeRTOS

- "src/**"
- "samples/zephyr/**"
- "tests/zephyr/**"
- "west-ncs.yml"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also gate on changes to zephyr/module.yml (in case blobs change)?

I do see run: west blobs fetch hubblenetwork-sdk done in the build, so it isn't strictly necessary, but it seems good to be explicit

Since zephyr-tests.yaml adds tools/ci/twister-quarantine.yaml, I would here too, for continuity. Like the above note, I think it isn't strictly necessary. i.e. a new build is quarantined because it broke due to a change in src/, the change in src/ would gate the build, and the build skips anything in the updated quarantine

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point I'll include the module.yml. For the quarantine, that was my initial thought as well, although I can add it for consistency with vanilla zephyr tests.

Update the CI build for each port to include paths to source code
that would benefit from a CI rebuild to check for issues.

Signed-off-by: Hong Nguyen <hong@hubble.com>
@Micahscope

Copy link
Copy Markdown
Collaborator

LGTM; will let someone with better CI experience complete final approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants