Skip to content

Changed beta to beta_s when passing to UMM - #22

Merged
skygering merged 1 commit into
masterfrom
sg/umm_compat_fix
Jul 30, 2026
Merged

Changed beta to beta_s when passing to UMM#22
skygering merged 1 commit into
masterfrom
sg/umm_compat_fix

Conversation

@skygering

Copy link
Copy Markdown
Contributor

You're making a pull request to a branch (probably main) of MITWindFarm. Please ensure you have done the following.

  • Request a review from other Howland Lab members who use MITWindFarm.
  • Add at least a sentence on your change to the documentation (probably the quickstart guide).
  • Add tests for your new functionality.
  • Make sure the tests pass and the documentation notebook still runs.
  • Get approval from the folks you requested a review from.

If you want more details on best practices, please see the following guide on the Howland Lab Google Drive.

Happy merging!

@skygering skygering self-assigned this Jul 23, 2026
@skygering
skygering requested a review from iupfal July 23, 2026 18:38
@skygering

Copy link
Copy Markdown
Contributor Author

Do you think we should change the keyword in MITRotor to beta_s too? Will the beta for blockage make its way to MITRotor?

@iupfal iupfal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minor change updated for compatibility with the new version of the UMM repository. This looks good to me

@skygering
skygering merged commit eb5d016 into master Jul 30, 2026
5 checks passed
@skygering
skygering deleted the sg/umm_compat_fix branch July 30, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants