Repository navigation
Plan: rebase the nested class fix (#907) and reword one test docstring - #6
honeybeartech-homelab-automation[bot] wants to merge 3 commits into
Conversation
Signed-off-by: Sean Stoube <31805425+HoneyBearTech@users.noreply.github.com>
|
@HoneyBearTech The plan for the custom-components#907 follow-up (rebase plus one docstring) is ready. Please approve this PR (or comment "approve") to start the work. |
…#875) A class defined inside a class body was left on the outer class as the internal EvalLocalVar placeholder instead of the class itself. So after the outer class was created, Outer.Inner | None raised the same TypeError as in custom-components#875, and type(Outer.Inner()) is Outer.Inner was False. Before the outer class is created, replace each defined EvalLocalVar in a plain dict class namespace with the value it holds. The placeholders themselves are left alone, so methods that read the nested class by its bare name keep working as before. A class namespace that isn't a plain dict, such as a mapping returned by a custom metaclass __prepare__, is left as it is. Signed-off-by: Sean Stoube <31805425+HoneyBearTech@users.noreply.github.com>
Signed-off-by: Sean Stoube <31805425+HoneyBearTech@users.noreply.github.com>
|
@HoneyBearTech The custom-components#907 follow-up is built and checked, with nothing open. It's ready for your approval. DoneThe nested class fix now sits on upstream's latest code. Only the test file had a conflict: new upstream tests and ours had both been added at its end, so we kept both. The fix itself is unchanged. As the maintainer asked, the test Checks
Rejected findingsNone. After you approve
To approveApprove this PR (or comment "approve") to finish. Close it to throw the work away. |
This PR holds the plan for the follow-up on upstream custom-components/pyscript#907, the nested class fix. It stays on this fork and is never merged. Full plan and record:
docs/plans/nested-class-rebase.md. Its base is a copy of upstream's latestmaster, so this PR shows only our changes.What the maintainer asked for on custom-components#907: update it to current
master(it showed a conflict), and reword one test's description so it says the test records today's pyscript behaviour, which differs from Python.What's done: the fix now sits on upstream's latest code. Only the test file had a conflict: new upstream tests and ours had both been added at its end, so we kept both. The fix itself is unchanged. The test description now says it records today's behaviour, not the intended one.
Checks: all 217 tests and every code-style check the project runs pass. The security review and the independent code review found nothing.
After you approve: the new commit replaces the old one on the fork branch
fix-nested-class-attr. That updates custom-components#907 directly, and GitHub should then show it as ready to merge. This plan file does not go upstream. You'll get a short reply to paste on custom-components#907, because the app can't write on the upstream repo. The maintainer may need to approve custom-components#907 once more.Team: Engineer, Security Officer and Auditor. Research, the plan check and QA were skipped as too small for this job.
Contribution rules followed:
docs/contributing.rstandtests/README.md, pre-commit (ruff, codespell, pylint, mypy), CI on Python 3.14, one small fix per PR with tests, and commits signed off.Approve this PR (or comment "approve") to finish. Close it to throw the work away.