Skip to content

Extend sandboxing to package processing - #24038

Open
MikeMcQuaid wants to merge 1 commit into
mainfrom
sandbox-package-processing
Open

MikeMcQuaid wants to merge 1 commit into
mainfrom
sandbox-package-processing

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Limit downloaded package operations to their intended output paths and share sandbox setup with build, test and installation workers.
  • Preserve required download authentication, validate trust boundaries and warn when package processing proceeds without a sandbox.
  • Explain sandboxing principles and limitations in the security guide.

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex with GPT 6 Astra at Extra High effort, with local review and testing.


@MikeMcQuaid
MikeMcQuaid requested a review from a team as a code owner September 19, 2026 21:33
Copilot AI lite review requested due to automatic review settings September 19, 2026 21:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Run {

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

@MikeMcQuaid
MikeMcQuaid force-pushed the sandbox-package-processing branch 3 times, most recently from 92bc4e6 to 0f53cf2 Compare September 19, 2026 22:32
- Limit downloaded package operations to intended output paths and share
  sandbox setup with build, test and installation workers.
- Mount disk images read-only in the parent and sandbox extraction at
  each stage, without trusting archive-created symlinks for new grants.
- Load disk-image filtering helpers in workers and capture setup warnings
  without assuming standard error is a file.
- Keep formula test fixtures independent of the host's implicit toolchain
  dependencies while testing those dependencies explicitly.
- Allow padded prefixes inside the repository while protecting its code.
- Use the public `Keg` interface for sandboxed install linkage repairs.
- Preserve required download authentication, validate trust boundaries
  and warn when package processing proceeds without a sandbox.
- Explain sandboxing principles and limitations in the security guide.
@MikeMcQuaid
MikeMcQuaid force-pushed the sandbox-package-processing branch from 0f53cf2 to 0e42305 Compare September 20, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants