Extend sandboxing to package processing - #24038
Open
MikeMcQuaid wants to merge 1 commit into
Open
MikeMcQuaid wants to merge 1 commit into
MikeMcQuaid wants to merge 1 commit into
Conversation
Contributor
|
One or more custom setup steps configured for this repository failed during this Copilot code review run: Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review. Note You can configure setup steps for Copilot code review separately from Copilot cloud agent with a |
MikeMcQuaid
force-pushed
the
sandbox-package-processing
branch
3 times, most recently
from
September 19, 2026 22:32
92bc4e6 to
0f53cf2
Compare
- Limit downloaded package operations to intended output paths and share sandbox setup with build, test and installation workers. - Mount disk images read-only in the parent and sandbox extraction at each stage, without trusting archive-created symlinks for new grants. - Load disk-image filtering helpers in workers and capture setup warnings without assuming standard error is a file. - Keep formula test fixtures independent of the host's implicit toolchain dependencies while testing those dependencies explicitly. - Allow padded prefixes inside the repository while protecting its code. - Use the public `Keg` interface for sandboxed install linkage repairs. - Preserve required download authentication, validate trust boundaries and warn when package processing proceeds without a sandbox. - Explain sandboxing principles and limitations in the security guide.
MikeMcQuaid
force-pushed
the
sandbox-package-processing
branch
from
September 20, 2026 04:44
0f53cf2 to
0e42305
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.