Skip to content

Allow --formula-list with --new-history - #24037

Merged
p-linnane merged 1 commit into
mainfrom
advisory-daily-formula-list
Sep 19, 2026
Merged

p-linnane merged 1 commit into
mainfrom
advisory-daily-formula-list

Conversation

@p-linnane

Copy link
Copy Markdown
Contributor

--formula-list only worked with --reconcile-history. Accept it with --new-history too, so the advisory database can run daily matching in bounded formula-list workers; bulk queries and index-only Repology lookups are unchanged, and a list without a history mode is a usage error.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

OpenAI Codex drafted the change and tests; Claude Code (Fable 5.1) reviewed the diff. I reviewed the diff and commit message before pushing.


Daily ingest is being split into bounded workers that each match a
fixed list of core formulae, but `--formula-list` was tied to
`--reconcile-history`. Accept it with `--new-history` as well, keeping
bulk queries and the Repology index without live fallbacks, and reject
a list given without either history mode.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
Copilot AI lite review requested due to automatic review settings September 19, 2026 20:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@p-linnane
p-linnane added this pull request to the merge queue Sep 19, 2026
Merged via the queue into main with commit b1d4cf0 Sep 19, 2026
53 of 54 checks passed
@p-linnane
p-linnane deleted the advisory-daily-formula-list branch September 19, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants