Skip to content

pypi: resolve non-PyPI sources missing from PyPI - #24036

Merged
MikeMcQuaid merged 1 commit into
mainfrom
pypi-url-package-extras
Sep 19, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
pypi-url-package-extras

Conversation

@daeho-ro

Copy link
Copy Markdown
Member

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Claude is used to create codes but tested and reviewed by myself.


package_name was always looked up on PyPI as name[extras]==<formula version>, which fails when a formula built from a non-PyPI source (e.g. a GitHub release) uses a version PyPI does not have, as with hermes-agent.

In that case, resolve the stable URL as a PEP 508 direct reference (name[extras] @ <url>) so extras' dependencies are kept. Formulae whose version exists on PyPI are unaffected.

- `package_name` was always looked up on PyPI as
  `name[extras]==<formula version>`, which fails when a formula built
  from a non-PyPI source (e.g. a GitHub release) uses a version PyPI
  does not have, as with `hermes-agent`.
- In that case, resolve the stable URL as a PEP 508 direct reference
  (`name[extras] @ <url>`) so extras' dependencies are kept.
- Formulae whose version exists on PyPI are unaffected.
Copilot AI lite review requested due to automatic review settings September 19, 2026 10:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@saitanallensantiago26-beep

This comment was marked as low quality.

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 19, 2026
Merged via the queue into main with commit 9160219 Sep 19, 2026
52 of 53 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the pypi-url-package-extras branch September 19, 2026 20:51
@dot-agi

dot-agi commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Thank you! Makes life easier for maintaining the hermes-agent formula.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants