Type Formulary options instead of **options - #24032
Merged
Merged
Conversation
- `from_rack` and `from_keg` built an options hash only to splat it into `factory`, so Sorbet skipped keyword checking on those calls and a mistyped keyword raised only at runtime. - Pass each callee's keywords explicitly. `.compact` was a no-op: the only key it could drop was `alias_path`, which `factory` and `from_keg` already default to nil. - Replace the `*spec` positional splats, which disabled arity and type checking the same way, with the callee's own default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formulary.from_rackandfrom_kegeach built an options hash only to splat it intofactory, and a**hashsplat makes Sorbet skip keyword checking for the whole call, so a mistyped keyword raised anArgumentErrorat runtime instead of failingbrew typecheck. Pass each callee's keywords explicitly instead..compactwas a no-op here: the only key it could drop wasalias_path, whichfactoryandfrom_kegboth already default to nil. The*specpositional splats go too, since a positional splat disables arity and type checking the same way, sofactory's own:stabledefault is now spelled out at the two call sites that relied on it.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude Code with Opus 5, with local review and testing.