Conversation
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Not accepting PRs until 7.0.0 launched.
|
Please provide a screenshot of before/after. |
|
Could you please fix the SwiftLint issue(s) and figure out why the UI tests are failing, fixing them if you can. |
|
Im not sure if the build tests will pass but on my end it all works seamlessly |
|
Thanks for your pull request. This has been closed because it appears to be missing the current pull request template. Please describe the problem, the change and how you verified it. Please edit this pull request to fill in the current pull request template. This workflow will reopen this pull request automatically once the template is complete. Do not open a new pull request for this. |
|
I accidentally closed the PR instead of sending my message. Oops |
|
I don't think my new commits are shown here now. Should I open a new pull request. Sorry for the inconvenience. |
|
Let's discuss here first so you don't waste your time. |


PR: Add 'Hide dependencies' filter checkbox to Installed packages view
Summary
Adds an optional "Hide dependencies" checkbox toggle to the Installed packages view, allowing users to filter the list down to explicitly requested packages (
installedOnRequest) and reduce clutter from secondary dependencies.Changes
UI & Presentation
InstalledPackagesView: Added ahideDependenciesTogglecheckbox beneath the scope picker, styled with.brewSubheadlineand secondary text coloring.View Model & Filtering
InstalledViewModel:hideDependencies: Bool(defaults tofalse).InstalledPackagesContent.filtered(hidingDependencies:)andfilteredContent(...)to filter by\.installedOnRequest.updateSelectionForFilterChange) to handle row preview fallbacks and restorations when toggling the dependency filter.Accessibility & Test Support
BrewAccessibilityID: Added.installedHideDependenciesCheckbox("installed.hideDependencies") toAXIDand verified wire-format inAXIDTests.InstalledScreen: AddedhideDependenciesCheckboxandtoggleHideDependencies()helpers for UI tests.BrewPackageFixtures: AddedinstalledOnRequestparameter toInstalledBrewPackage.fixture(defaults totrue).InstalledViewModelHideDependenciesTests: Added unit test coverage for default state, filtering direct vs. dependency packages, composition with scope picker and search queries, and row selection fallback/restoration.Why this split (optional)
Leverages the existing
installedOnRequestflag already exposed byInstalledBrewPackageto provide immediate filtering capability in the Installed tab without modifying the underlying data layer or database schema.Testing
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer swift test --filter BrewFeatureInstalledTests(226 tests passed across 26 suites).AXIDTests.hideDependencies.PR checklist
Follow-ups (optional)