Skip to content

feat(c-glib): add fixed and variable closedness range GLib bindings #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hoeze-minion wants to merge 2 commits into
base: feat/arrow-range-extension
Choose a base branch
from
Draft

feat(c-glib): add fixed and variable closedness range GLib bindings #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5119c0f
feat(c-glib): add fixed closedness range GLib bindings
Hoeze Sep 25, 2026
364266e
feat(c-glib): add variable closedness range GLib bindings
Hoeze Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
211 changes: 211 additions & 0 deletions c_glib/arrow-glib/basic-data-type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

#include <arrow/c/bridge.h>
#include <arrow/extension/fixed_shape_tensor.h>
#include <arrow/extension/range.h>
#include <arrow/extension/uuid.h>

G_BEGIN_DECLS
Expand Down Expand Up @@ -2591,6 +2592,212 @@ garrow_uuid_data_type_new(GError **error)
return NULL;
}
}

static arrow::extension::RangeClosed
garrow_range_closed_to_raw(GArrowRangeClosed closed)
{
switch (closed) {
case GARROW_RANGE_CLOSED_LEFT:
return arrow::extension::RangeClosed::Left;
case GARROW_RANGE_CLOSED_RIGHT:
return arrow::extension::RangeClosed::Right;
case GARROW_RANGE_CLOSED_BOTH:
return arrow::extension::RangeClosed::Both;
case GARROW_RANGE_CLOSED_NEITHER:
return arrow::extension::RangeClosed::Neither;
default:
return arrow::extension::RangeClosed::Left;
}
}

static GArrowRangeClosed
garrow_range_closed_from_raw(arrow::extension::RangeClosed closed)
{
switch (closed) {
case arrow::extension::RangeClosed::Left:
return GARROW_RANGE_CLOSED_LEFT;
case arrow::extension::RangeClosed::Right:
return GARROW_RANGE_CLOSED_RIGHT;
case arrow::extension::RangeClosed::Both:
return GARROW_RANGE_CLOSED_BOTH;
case arrow::extension::RangeClosed::Neither:
return GARROW_RANGE_CLOSED_NEITHER;
default:
return GARROW_RANGE_CLOSED_LEFT;
}
}

G_DEFINE_TYPE(GArrowFixedClosednessRangeDataType,
garrow_fixed_closedness_range_data_type,
GARROW_TYPE_EXTENSION_DATA_TYPE)

static void
garrow_fixed_closedness_range_data_type_init(GArrowFixedClosednessRangeDataType *object)
{
}

static void
garrow_fixed_closedness_range_data_type_class_init(
GArrowFixedClosednessRangeDataTypeClass *klass)
{
}

/**
* garrow_fixed_closedness_range_data_type_new:
* @value_type: The orderable #GArrowDataType of the lower and upper bounds.
* @closed: Which bound(s) of the interval are inclusive.
* @allow_unbounded: Whether each side may be unbounded (infinite); when %TRUE
* the lower/upper fields are nullable, when %FALSE they are non-nullable and
* the range is always finite.
* @error: (nullable): Return location for a #GError or %NULL.
*
* Returns: (nullable):
* The newly created fixed closedness range data type on success, %NULL on
* error.
*
* Since: 26.0.0
*/
GArrowFixedClosednessRangeDataType *
garrow_fixed_closedness_range_data_type_new(GArrowDataType *value_type,
GArrowRangeClosed closed,
gboolean allow_unbounded,
GError **error)
{
auto arrow_value_type = garrow_data_type_get_raw(value_type);
auto arrow_closed = garrow_range_closed_to_raw(closed);
auto arrow_data_type_result =
arrow::extension::FixedClosednessRangeType::Make(arrow_value_type,
arrow_closed,
allow_unbounded);
if (garrow::check(error,
arrow_data_type_result,
"[fixed-closedness-range-data-type][new]")) {
auto arrow_data_type = *arrow_data_type_result;
return GARROW_FIXED_CLOSEDNESS_RANGE_DATA_TYPE(
g_object_new(GARROW_TYPE_FIXED_CLOSEDNESS_RANGE_DATA_TYPE,
"data-type",
&arrow_data_type,
NULL));
} else {
return NULL;
}
}

/**
* garrow_fixed_closedness_range_data_type_get_value_type:
* @data_type: A #GArrowFixedClosednessRangeDataType.
*
* Returns: (transfer full): The orderable #GArrowDataType of the lower
* and upper bounds.
*
* Since: 26.0.0
*/
GArrowDataType *
garrow_fixed_closedness_range_data_type_get_value_type(
GArrowFixedClosednessRangeDataType *data_type)
{
auto arrow_data_type =
std::static_pointer_cast<arrow::extension::FixedClosednessRangeType>(
garrow_data_type_get_raw(GARROW_DATA_TYPE(data_type)));
auto arrow_value_type = arrow_data_type->value_type();
return garrow_data_type_new_raw(&arrow_value_type);
}

/**
* garrow_fixed_closedness_range_data_type_get_closed:
* @data_type: A #GArrowFixedClosednessRangeDataType.
*
* Returns: Which bound(s) of the interval are inclusive.
*
* Since: 26.0.0
*/
GArrowRangeClosed
garrow_fixed_closedness_range_data_type_get_closed(
GArrowFixedClosednessRangeDataType *data_type)
{
auto arrow_data_type =
std::static_pointer_cast<arrow::extension::FixedClosednessRangeType>(
garrow_data_type_get_raw(GARROW_DATA_TYPE(data_type)));
return garrow_range_closed_from_raw(arrow_data_type->closed());
}

G_DEFINE_TYPE(GArrowVariableClosednessRangeDataType,
garrow_variable_closedness_range_data_type,
GARROW_TYPE_EXTENSION_DATA_TYPE)

static void
garrow_variable_closedness_range_data_type_init(
GArrowVariableClosednessRangeDataType *object)
{
}

static void
garrow_variable_closedness_range_data_type_class_init(
GArrowVariableClosednessRangeDataTypeClass *klass)
{
}

/**
* garrow_variable_closedness_range_data_type_new:
* @value_type: The orderable #GArrowDataType of the lower and upper bounds.
* @allow_unbounded: Whether each side may be unbounded (infinite); when %TRUE
* the lower/upper fields are nullable, when %FALSE they are non-nullable and
* the range is always finite. The lower_inc/upper_inc fields are always
* non-nullable.
* @error: (nullable): Return location for a #GError or %NULL.
*
* Unlike #GArrowFixedClosednessRangeDataType, the inclusivity of each bound
* is stored per value in boolean lower_inc/upper_inc fields rather than as a
* single type-level parameter, so there is no closed argument.
*
* Returns: (nullable):
* The newly created variable closedness range data type on success, %NULL
* on error.
*
* Since: 26.0.0
*/
GArrowVariableClosednessRangeDataType *
garrow_variable_closedness_range_data_type_new(GArrowDataType *value_type,
gboolean allow_unbounded,
GError **error)
{
auto arrow_value_type = garrow_data_type_get_raw(value_type);
auto arrow_data_type_result =
arrow::extension::VariableClosednessRangeType::Make(arrow_value_type,
allow_unbounded);
if (garrow::check(error,
arrow_data_type_result,
"[variable-closedness-range-data-type][new]")) {
auto arrow_data_type = *arrow_data_type_result;
return GARROW_VARIABLE_CLOSEDNESS_RANGE_DATA_TYPE(
g_object_new(GARROW_TYPE_VARIABLE_CLOSEDNESS_RANGE_DATA_TYPE,
"data-type",
&arrow_data_type,
NULL));
} else {
return NULL;
}
}

/**
* garrow_variable_closedness_range_data_type_get_value_type:
* @data_type: A #GArrowVariableClosednessRangeDataType.
*
* Returns: (transfer full): The orderable #GArrowDataType of the lower
* and upper bounds.
*
* Since: 26.0.0
*/
GArrowDataType *
garrow_variable_closedness_range_data_type_get_value_type(
GArrowVariableClosednessRangeDataType *data_type)
{
auto arrow_data_type =
std::static_pointer_cast<arrow::extension::VariableClosednessRangeType>(
garrow_data_type_get_raw(GARROW_DATA_TYPE(data_type)));
auto arrow_value_type = arrow_data_type->value_type();
return garrow_data_type_new_raw(&arrow_value_type);
}
G_END_DECLS

GArrowDataType *
Expand Down Expand Up @@ -2746,6 +2953,10 @@ garrow_data_type_new_raw(std::shared_ptr<arrow::DataType> *arrow_data_type)
type = GARROW_TYPE_FIXED_SHAPE_TENSOR_DATA_TYPE;
} else if (name == "arrow.uuid") {
type = GARROW_TYPE_UUID_DATA_TYPE;
} else if (name == "arrow.fixed_closedness_range") {
type = GARROW_TYPE_FIXED_CLOSEDNESS_RANGE_DATA_TYPE;
} else if (name == "arrow.variable_closedness_range") {
type = GARROW_TYPE_VARIABLE_CLOSEDNESS_RANGE_DATA_TYPE;
} else {
auto g_extension_data_type =
std::dynamic_pointer_cast<garrow::GExtensionType>(*arrow_data_type);
Expand Down
75 changes: 75 additions & 0 deletions c_glib/arrow-glib/basic-data-type.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,4 +894,79 @@ struct _GArrowUUIDDataTypeClass
GARROW_AVAILABLE_IN_21_0
GArrowUUIDDataType *
garrow_uuid_data_type_new(GError **error);

/**
* GArrowRangeClosed:
* @GARROW_RANGE_CLOSED_LEFT: Lower bound is inclusive, upper bound is
* exclusive: [lower, upper).
* @GARROW_RANGE_CLOSED_RIGHT: Lower bound is exclusive, upper bound is
* inclusive: (lower, upper].
* @GARROW_RANGE_CLOSED_BOTH: Both bounds are inclusive: [lower, upper].
* @GARROW_RANGE_CLOSED_NEITHER: Both bounds are exclusive: (lower, upper).
*
* They are corresponding to `arrow::extension::RangeClosed` values.
*
* Since: 26.0.0
*/
typedef enum {
GARROW_RANGE_CLOSED_LEFT,
GARROW_RANGE_CLOSED_RIGHT,
GARROW_RANGE_CLOSED_BOTH,
GARROW_RANGE_CLOSED_NEITHER,
} GArrowRangeClosed;

#define GARROW_TYPE_FIXED_CLOSEDNESS_RANGE_DATA_TYPE \
(garrow_fixed_closedness_range_data_type_get_type())
GARROW_AVAILABLE_IN_26_0
G_DECLARE_DERIVABLE_TYPE(GArrowFixedClosednessRangeDataType,
garrow_fixed_closedness_range_data_type,
GARROW,
FIXED_CLOSEDNESS_RANGE_DATA_TYPE,
GArrowExtensionDataType)
struct _GArrowFixedClosednessRangeDataTypeClass
{
GArrowExtensionDataTypeClass parent_class;
};

GARROW_AVAILABLE_IN_26_0
GArrowFixedClosednessRangeDataType *
garrow_fixed_closedness_range_data_type_new(GArrowDataType *value_type,
GArrowRangeClosed closed,
gboolean allow_unbounded,
GError **error);

GARROW_AVAILABLE_IN_26_0
GArrowDataType *
garrow_fixed_closedness_range_data_type_get_value_type(
GArrowFixedClosednessRangeDataType *data_type);

GARROW_AVAILABLE_IN_26_0
GArrowRangeClosed
garrow_fixed_closedness_range_data_type_get_closed(
GArrowFixedClosednessRangeDataType *data_type);

#define GARROW_TYPE_VARIABLE_CLOSEDNESS_RANGE_DATA_TYPE \
(garrow_variable_closedness_range_data_type_get_type())
GARROW_AVAILABLE_IN_26_0
G_DECLARE_DERIVABLE_TYPE(GArrowVariableClosednessRangeDataType,
garrow_variable_closedness_range_data_type,
GARROW,
VARIABLE_CLOSEDNESS_RANGE_DATA_TYPE,
GArrowExtensionDataType)
struct _GArrowVariableClosednessRangeDataTypeClass
{
GArrowExtensionDataTypeClass parent_class;
};

GARROW_AVAILABLE_IN_26_0
GArrowVariableClosednessRangeDataType *
garrow_variable_closedness_range_data_type_new(GArrowDataType *value_type,
gboolean allow_unbounded,
GError **error);

GARROW_AVAILABLE_IN_26_0
GArrowDataType *
garrow_variable_closedness_range_data_type_get_value_type(
GArrowVariableClosednessRangeDataType *data_type);

G_END_DECLS
Loading
Loading