Repository navigation
Calendar: subscribe the mail handler as an events queue - #138
Merged
Merged
Conversation
Use queue: true instead of delivery/targets, check for an app identity before subscribing now that invalid_targets is gone, and mark the handler's temporary failures retry: true so they are still retried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with HeyPuter/puter#4395 and should roll out with it. Old code keeps working against the new server, but this avoids the worker delay and the removed fields.
queue: trueinstead ofdelivery: 'single', targets: ['worker']. The page never registers an in-page handler, so an open tab declines each delivery and the events worker runs it right away.invalid_targetsno longer exists, so the mailbox checksputer.appIDbefore subscribing and falls back to foreground scanning without one.retry: trueso the classification stays the handler's. Everything else is still swallowed and marked seen.The handler source changed, so it needs
npm run publish:mail-handlerafter merge.