Repository navigation
add graphic designer portfolio template - #22
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Poster text contrast is insufficient, and mobile users lose section navigation.
3 open findings
What changed in this PR
Adds a graphic designer portfolio to the template catalog as an editable, one-page site.
Changes:
- Registers the template and adds its catalog description and customization suggestions.
- Adds the portfolio page, styles, favicon, and scripts for project cards, services, work history, and contact.
| File | Description |
|---|---|
src/templates/index.js |
Registers the new template. |
src/templates/designer-portfolio/template.js |
Defines catalog content and suggestions. |
src/templates/designer-portfolio/files/styles.css |
Styles the page and responsive layouts. |
src/templates/designer-portfolio/files/index.html |
Defines the page structure and content. |
src/templates/designer-portfolio/files/icon.svg |
Adds the favicon. |
src/templates/designer-portfolio/files/app.js |
Renders portfolio data and interactions. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const li = el('li'); | ||
| const dots = el('div', 'dots'); | ||
| dots.append(el('i'), el('i'), el('i')); | ||
| const h = el('h3'); |
| .stamp { left: auto; right: 0; bottom: -2%; } | ||
| } | ||
| @media (max-width: 560px) { | ||
| .hero-nav nav, .reg, .crop { display: none; } |
Comment on lines
+109
to
+115
| .meta-row { display: flex; justify-content: space-between; color: var(--paper); font-family: var(--mono); font-size: 0.85rem; letter-spacing: 0.1em; text-transform: uppercase; align-items: baseline; } | ||
| .meta-row b { font-family: var(--sans); font-weight: 900; font-stretch: 125%; font-size: 2.6rem; letter-spacing: -0.02em; line-height: 1; } | ||
| .big { | ||
| font-family: var(--sans); font-weight: 900; font-stretch: 112%; text-transform: uppercase; | ||
| font-size: clamp(3rem, 8.4vw, 7.4rem); line-height: 0.86; letter-spacing: -0.03em; margin-top: clamp(28px, 4vw, 56px); | ||
| } | ||
| .big .a { color: var(--sand); display: block; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.