Skip to content

fix(rest): parse bundle entry URLs without their query string #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smunini merged 5 commits into from
Aug 19, 2026
+565 −17
Merged

fix(rest): parse bundle entry URLs without their query string #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
26d0a22
fix(rest): parse bundle entry URLs without their query string
aacruzgon Aug 5, 2026
861225e
fix(rest): decline transaction entries whose URL carries a query
aacruzgon Aug 5, 2026
c0ea652
docs(rest): correct the bundle conditional-header claims
aacruzgon Aug 5, 2026
263ca74
docs(rest): correct the GET-exemption rationale in the transaction guard
aacruzgon Aug 5, 2026
6cf3c53
test(rest): assert the query-guard refusal on the field the server ac…
aacruzgon Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions crates/rest/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,16 +501,32 @@ curl -X POST http://localhost:8080/ \

### Conditional Operations in Bundles

Bundle entries support conditional headers:
- `ifMatch` - ETag for optimistic locking on `PUT` **and `DELETE`** entries, in
both `batch` and `transaction` bundles. Parsed as the comma-separated list
RFC 9110 §13.1.1 defines: satisfied when any supplied entity-tag matches.
- `ifNoneMatch` - Prevent overwrites (`*` for conditional create)
- `ifNoneExist` - Search query for conditional create
- `ifMatch` — **supported.** ETag for optimistic locking on `PUT` **and `DELETE`**
entries, in both `batch` and `transaction` bundles. Parsed as the comma-separated
list RFC 9110 §13.1.1 defines: satisfied when any supplied entity-tag matches.
- `ifNoneMatch` — **parsed and ignored.** `parse_bundle_entry` populates
`BundleEntry.if_none_match`; no handler or backend reads it.
- `ifNoneExist` — **MongoDB transactions only.** MongoDB resolves it inside the
bundle's session. The batch path never reads it, and SQLite/PostgreSQL ignore it
in a transaction and create a duplicate. Tracked by #511.

Conditional interactions expressed in the entry URL (`PUT [type]?[criteria]`,
`DELETE [type]?[criteria]`) are **not resolved**:

- In a `batch`, such an entry is refused per-entry with `400`; nothing is written.
- In a `transaction`, any non-`GET` entry whose URL carries a query string
declines the whole bundle with `400 not-supported` before anything executes,
because the backends parse entry URLs query-blind and would otherwise commit
the criteria as part of the resource type or the id.

Note that `/metadata` advertises `conditionalCreate`, `conditionalUpdate` and
`conditionalDelete` for every resource type. That is accurate for the resource
endpoints and **not** for bundle entries; reconciling the two is #511.

### Current Limitations

The following FHIR transaction features are not yet implemented:
- **Conditional interactions in bundle entries** - `[type]?[criteria]` URLs are refused rather than resolved (#511)
- **Conditional reference resolution** - References like `Patient?identifier=12345` are not resolved
- **PATCH method** - PATCH operations in bundles return 501 Not Implemented
- **Prefer header** - `return=minimal` and `return=OperationOutcome` not honored
Expand Down
Loading
Loading