ci: bump ai-review-prompts pin to 20c2157 (post #37)#561
Open
heskew wants to merge 2 commits into
Open
Conversation
DO NOT MERGE. Diagnostic branch to capture the actual crash signature
when `restart_service { service: 'http_workers' }` runs inside the
blob component test context on Windows.
Removes both the suite-level Windows skip and the two per-test
restart_service Windows skips in 23_blob.mjs. The existing
`run-integration-apiTests-windows` CI job will run, the blob context
will trigger the crash Kris documented in `0751644f`, and the existing
`harper-integration-api-test-logs-windows` artifact upload will
capture hdb.log + stdouts + stderrs for analysis.
Once the artifact is downloaded and #549 has a real stack trace,
this branch should be closed without merging — the production fix
lives in `lmdb-js` native binding cleanup or in Harper's worker
shutdown ordering, neither of which involves un-skipping these tests
in this manner.
Picks up the new `harper/common.md` content from ai-review-prompts#37: - Meta-checks (test validity, right target, premise) at the top of the layer file — to be run before tracing internals - Existing-dependency reuse, CI workflow hygiene, lockfile drift bullets added to the "Review checks specific to Harper" section Each rule is sourced from a specific miss in this week's ai-review-log triage. No workflow logic changes; pure content layer update. Previously on the pre-calibration #20 pin from 2026-05-09 (title format + areas-not-traced); now catching up through #37. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the new
harper/common.mdcontent from HarperFast/ai-review-prompts#37:copyDbToRocksedited whenmigrateOnStartwas the real path)No workflow logic changes; pure content layer update. Previously on the post-#20 pin from 2026-05-09 (title format + areas-not-traced + dev/prod dep rule); now catching up through #37.
🤖 Generated with Claude Code