fix(table): eviction never starts for sourcedFrom and eviction-only tables#560
Open
ldt1996 wants to merge 3 commits into
Open
fix(table): eviction never starts for sourcedFrom and eviction-only tables#560ldt1996 wants to merge 3 commits into
ldt1996 wants to merge 3 commits into
Conversation
ldt1996
changed the title
Contributor
|
Reviewed; no blockers found. |
ldt1996
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #559
closes #558
Found this while testing v4 to v5 in place upgrade on my cluster. Migration
went ok for the non-blob tables but the 2 blob tables came up short (eg 14672 vs 25611, 13795 vs 19651).
Replication ENOENTs from v4 peers pointed at blob files that no longer existed. When looking into it, the records referencing those "dead" blobs hadn't aged out either, and 90%+ were past their exp time, oldest expired 9 days ago. The affected tables showed
"expiration": "NaNs"(see more in the issues tagged above).Reproduced locally via the unit test (
caching.test.js, fails on main, passes here). Alsoconfirmed end-to-end on a daemon repro against
harperdb@4.7.28.