spike(#549): capture restart_service crash signature on Windows (DO NOT MERGE)#556
Closed
heskew wants to merge 1 commit into
Closed
spike(#549): capture restart_service crash signature on Windows (DO NOT MERGE)#556heskew wants to merge 1 commit into
heskew wants to merge 1 commit into
Conversation
DO NOT MERGE. Diagnostic branch to capture the actual crash signature
when `restart_service { service: 'http_workers' }` runs inside the
blob component test context on Windows.
Removes both the suite-level Windows skip and the two per-test
restart_service Windows skips in 23_blob.mjs. The existing
`run-integration-apiTests-windows` CI job will run, the blob context
will trigger the crash Kris documented in `0751644f`, and the existing
`harper-integration-api-test-logs-windows` artifact upload will
capture hdb.log + stdouts + stderrs for analysis.
Once the artifact is downloaded and #549 has a real stack trace,
this branch should be closed without merging — the production fix
lives in `lmdb-js` native binding cleanup or in Harper's worker
shutdown ordering, neither of which involves un-skipping these tests
in this manner.
Contributor
|
Reviewed; no blockers found. Diagnostic-only branch — the three skip removals match the stated purpose exactly. |
Member
Author
|
Spike complete. Crash signature captured and attached to #549. Closing without merge as planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE — diagnostic branch only.
Purpose
Trigger the existing `run-integration-apiTests-windows` CI job against an unskipped `23_blob.mjs` so we capture the actual crash signature for #549. The crash was documented in commit `0751644f` ("'restart_service' operation for 'http_workers' in 23_blob.mjs causes the HarperDB process to crash") but no stack trace was ever preserved.
What this branch does
Removes the three Windows skips in `integrationTests/apiTests/tests/23_blob.mjs`:
Every other Windows skip elsewhere in the apiTests suite remains untouched. No source code change.
What happens
After the run
restart_servicecrash blocking component-load test paths #549The production fix for the underlying crash lives in `lmdb-js` native binding cleanup or in Harper's worker shutdown ordering — neither involves un-skipping these tests in this manner. This is purely a diagnostic capture.
Note re: Kris's PR #555
#555 is migrating the apiTests suite to the new `@harperfast/integration-testing` framework on isolated per-test-file Harper instances. It does not touch `23_blob.mjs` in this first slice. Spike and #555 don't conflict at the file level.
🤖 Generated with Claude Code