make read txn timeout configurable and set default to 1min#304
Open
ldt1996 wants to merge 6 commits into
Open
Conversation
kriszyp
requested changes
Mar 31, 2026
Member
kriszyp
left a comment
kriszyp
left a comment
There was a problem hiding this comment.
Thank for getting this configuration in!
| const trackedTxns: WeakRef<any>[] = []; | ||
| setInterval(() => { | ||
| const configValue = envMngr.get(CONFIG_PARAMS.STORAGE_MAXREADTRANSACTIONOPENTIME) ?? 60000; | ||
| let READ_TXN_TIMEOUT_TICKS = Math.round(Math.min(Math.max(configValue, 15000), 300000) / 15000); // clamp between 15s and 5min |
Member
There was a problem hiding this comment.
I don't think we actually need to clamp this. I know I had mentioned concerns about excessively long timeouts here, but that was more of a consideration for those setting the value, but I trust that we can set the value properly. And I think that a default of one minute is too short. I believe the previous setting was 15 minutes, right? Maybe the default should be 5 minutes?
DavidCockerill
approved these changes
Mar 31, 2026
Ethan-Arrowood
approved these changes
Apr 1, 2026
cb1kenobi
approved these changes
Apr 21, 2026
Member
cb1kenobi
left a comment
cb1kenobi
left a comment
There was a problem hiding this comment.
Code looks fine, but the title of the PR is confusing. It says "1min", though I don't see any 1 minute timeouts.
Co-authored-by: Chris Barber <chris@harperdb.io>
Contributor
Author
|
@cb1kenobi it was 1 min initially but updated it to 5 min as per Kris' recommendation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is 1min as default ideal, or should we set another timeout?