feat(docker-in-docker)!: run the daemon rootless without privileged - #42
Open
Hansehart wants to merge 1 commit into
Open
feat(docker-in-docker)!: run the daemon rootless without privileged#42Hansehart wants to merge 1 commit into
Hansehart wants to merge 1 commit into
Conversation
The feature declared privileged, which the CLI applies to the whole dev container, so anyone in the docker group could start a privileged nested container and mount the host disk. Run dockerd rootless instead and drop privileged. This needs file-capability newuidmap instead of setuid, /dev/net/tun created at start, and --pidns so RootlessKit mounts a writable procfs. daemonJson now also lands in the remote user's config directory, which is where the rootless daemon reads it. BREAKING CHANGE: DOCKER_HOST moves to the remote user's socket and a non-root remoteUser is now required, so this ships as 2.0.0. Consumers pinned to :1 keep the rootful feature and must opt in via :2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature declared privileged, which the CLI applies to the whole dev container, so anyone in the docker group could start a privileged nested container and mount the host disk. Run dockerd rootless instead and drop privileged.
This needs file-capability newuidmap instead of setuid, /dev/net/tun created at start, and --pidns so RootlessKit mounts a writable procfs. daemonJson now also lands in the remote user's config directory, which is where the rootless daemon reads it.
BREAKING CHANGE: DOCKER_HOST moves to the remote user's socket and a non-root remoteUser is now required, so this ships as 2.0.0. Consumers pinned to :1 keep the rootful feature and must opt in via :2.