Repository navigation
feat: prefer same-cwd entries for inline history suggestions - #1035
Open
ChanningHe wants to merge 1 commit into
Open
ChanningHe wants to merge 1 commit into
ChanningHe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inline history suggestions now prefer commands previously run in the current directory, falling back to the most recent global match.
Behavior
cwdequals the current directory; otherwise uses the most recent match as before.flyline history --backend flyline) recordscwd. With the bash backend, or entries imported from bash/zsh history, behavior is unchanged.Configuration
--inline-history-preferis an enum so other modes (session, host, workspace) can be added later without touching the history layer.Implementation
HistoryManager::get_command_suggestion_suffixtakes an optionalpreferpredicate and a scanwindow; it no longer knows aboutcwditself.Appcaches the shellcwdonce at startup and maps the setting to a predicate.Testing