Repository navigation
Match key bindings by base layout key on non-Latin layouts - #1016
Merged
Merged
Conversation
With the kitty keyboard protocol, ctrl+в on a Cyrillic layout arrives as ctrl+в rather than ctrl+d, so no binding matched. When nothing matches a key pressed with a command modifier, retry with the base layout key the terminal reports (the key at the same position in the US layout). Also parse single non-ASCII characters in bindings and remaps: the check counted bytes, so Cyrillic letters were rejected. Uses termina's new KeyEvent::base_layout_code. Fixes HalFrgrd#1000
Owner
|
Looks good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the kitty keyboard protocol enabled, ctrl+в on a Cyrillic layout arrives as ctrl+в rather than ctrl+d, so none of the default ctrl bindings fire, while plain readline gets the legacy
^Dbyte and works. Terminals that supportREPORT_ALTERNATE_KEYSalso send the base layout key (the key at the same position in the US layout); this uses it as a fallback. Fixes #1000.key bind/key remap: the length check counted bytes, so Cyrillic letters were rejectedDepends on HalFrgrd/termina#1 (
KeyEvent::base_layout_code).Cargo.tomlcurrently points at my termina fork; I'll switch it to the merged rev once that lands.