Repository navigation
Current stack joins the catalog - #460
Conversation
… prose A project's guidance held three rules the catalog lacked a record for: nothing hand-rolled where a maintained component does the job, a part a standard covers follows it, and the stack is the current one and not the one inherited. The first two are records; this adds the third. - current-stack (principle). A choice of language, runtime, framework, library, toolchain or service is judged on today's evidence of fit and upkeep, and being already in use is not a reason. Sources: Samuelson and Zeckhauser on status quo bias, Arkes and Blumer on sunk cost, McKinley's Choose Boring Technology as the counterweight, and OWASP A06. - It conflicts with chestertons-fence: one asks that the inherited thing be understood before it goes, the other that it not stay merely for being there. Both ends are written. does_not_mean hands the purpose question to the fence. - The record is registered in src/catalog.rs, the generated index and review documents are rebuilt, and policy/upheld.toml gains a review control so the review-carried record has a catches and a misses. Claude-Session: https://claude.ai/code/session_01EycJ7mB2AcGdDTvCuqtpmb
uphold-reviewGate alone under this owner: This App runs the gate alone for every pull request under this owner for now, so only uphold's rules ran. Use Full review on the uphold review check for a full review. ✅ uphold rules: uphold's rules pass · this repository's policy at aa6eca7Rule outputReviewed with uphold 1.39.0 by uphold-review 0.6.1 · 539b221 · claude-opus-5-5 · 17 s · $0.00 list |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Define and register the principle principles/current-stack.toml, src/catalog.rs, principles/chestertons-fence.toml |
Adds the principle record and registers it in the bundled catalog. The Chesterton’s Fence record now declares a conflict with Current Stack. |
Add review-control scenarios policy/upheld.toml, review-controls.json |
Adds caught and missed examples for toolchain pins justified by familiarity and for documenting a supported release. |
Document and index the principle AGENTS.md, REVIEW.md, QUICK_REFERENCE.md, name-index.json |
Adds review guidance, principle and alias listings, and searchable index entries. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Possibly related PRs
- HackingGate/uphold#411: Adds related dependency-currency review principles that the Current Stack record also references.
- HackingGate/uphold#423: Establishes caught and missed controls for review records; this change adds another control record.
- HackingGate/uphold#434: Adds validation for conflicting principles; this change declares a conflict between Current Stack and Chesterton’s Fence.
Merge Risk: 
Minimal · up to 539b2
-
The Current Stack catalog and guidance addition has no identified merge-blocking risk and is mergeable subject to normal checks.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (8 skipped: 8 unsupported.)
-
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 56 56
Lines 28550 28550
=======================================
Hits 27118 27118
Misses 1432 1432 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adds the catalog record for the third rule a project's guidance stated in prose, beside reuse-maintained-components and follow-published-standards: the stack is the current one, not the one inherited.
current-stack(principle, seed): a choice of language, runtime, framework, library, toolchain or service is judged on today's evidence of fit and upkeep; being already in use is not a reason. Sources: Samuelson and Zeckhauser (status quo bias), Arkes and Blumer (sunk cost), McKinley (Choose Boring Technology, the counterweight), OWASP A06.chestertons-fence; both ends written.does_not_meanhands the purpose question to the fence.src/catalog.rs;QUICK_REFERENCE.md,name-index.json,review-controls.json,REVIEW.mdandAGENTS.mdrebuilt;policy/upheld.tomlgains a review control (the self-application test requires one for a review-carried record).Checks: pre-commit hooks (catalog-validate, reference and review current, catalog-tests 189 OK, uphold-check, content-policy),
cargo testall green.https://claude.ai/code/session_01EycJ7mB2AcGdDTvCuqtpmb
Summary by CodeRabbit