[VIRTWINKVM-2679] Fix clean_boot not re-uploading test_binaries to guest - #1090
Merged
Conversation
Contributor
|
ok to test |
kostyanf14
reviewed
Aug 6, 2026
rachael-george
force-pushed
the
clean_boot_fix
branch
from
August 6, 2026 08:04
5f13fac to
9cda973
Compare
When clean_boot creates a fresh qcow2 overlay from the base image, previously uploaded test_binaries are lost. Call copy_test_binaries after reconnect in reboot_clean to restore them. Signed-off-by: rachael-george <rgeorge@redhat.com>
rachael-george
force-pushed
the
clean_boot_fix
branch
from
August 6, 2026 10:26
9cda973 to
3d4d0d0
Compare
kostyanf14
approved these changes
Aug 6, 2026
elizashurov
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a test case uses
clean_boot: true,reboot_cleancreates a fresh qcow2 overlay from the base image, which wipesC:\AutoHCK\test_binariesfrom the guest. Tests that reference@test_binaries_dir@after a clean boot fail with "file not found".This fix calls
copy_test_binariesafter reconnect in reboot_clean, matching whatprepare_machinealready does during initial setup.