Skip to content

Fix status width oscillation at fractional scales #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guzzo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix status width oscillation at fractional scales #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion hancore.shibumi.status/BarWidget.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,25 @@ Item {
property real spacingSavings: 0
property bool savingsPending: false
property bool spacingActive: false
property real spacingSavingsLeft: -1
property double spacingSavingsChangedAt: 0
// Settle after layout: binding width directly to snapped ink feeds the
// parent's new position back into its own reservation.
function syncSpacingSavings() {
if (!root || !spacingActive) return
const saved = Math.max(0, updateShift - bellShift)
savingsPending = false
if (Math.abs(spacingSavings - saved) > 1e-7) spacingSavings = saved
if (Math.abs(spacingSavings - saved) <= 1e-7) return
// Deferring alone does not settle it: a centered compact shell moves with
// its own width, and at fractional scales (1.25x) that move flips the
// snapped ink edges straight back, resizing the bar every frame. Ignore an
// immediate return to the value just left.
const now = Date.now()
if (Math.abs(saved - spacingSavingsLeft) <= 1e-7
&& now - spacingSavingsChangedAt < 500) return
spacingSavingsLeft = spacingSavings
spacingSavingsChangedAt = now
spacingSavings = saved
}
function scheduleSpacingSavings() {
savingsPending = true
Expand Down
3 changes: 3 additions & 0 deletions tests/status-plugin-regression.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ if ('else if (lifecycleBar && "tearingDown" in lifecycleBar\n'
raise SystemExit("Status no longer handles WidgetSlot's pre-destruction Bar revoke")
PY
printf 'status teardown ordering source guard passed\n'
rg -U -q 'Math\.abs\(saved - spacingSavingsLeft\) <= 1e-7\n[[:space:]]*&& now - spacingSavingsChangedAt < 500\) return' \
"$status_widget" \
|| fail "status spacing savings no longer settle a self-induced width cycle"
rg -Fq '["full", "icon", "text"]' "$status_widget" \
|| fail "status widget does not expose Full/Icon/Text display modes"
if rg -q 'SystemTray\.items|NotificationServer|makoctl|pgrep -x hypridle' \
Expand Down