Repository navigation
OmaQ 1.1.2: keep local file paths out of recall and edits - #63
Merged
Merged
Conversation
Up in omaq-connect recalled the display text of sent file and image items, "[file] <local path>", and Enter sent it as a chat message. Messages now carry their kind, and recall offers only text messages. In the bar, E started an edit on an own file or image item and put its local path into the composer. It now follows the Edit button, which is already hidden for those items. The PlainText gate pins the new ChatPage source hashes.
The manifest moves to 1.1.2, still Protocol 16. CURRENT.md and the terminal-client stage name 1.1.2 for the recall fix, and CURRENT.md says that editing applies to text messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OmaQ 1.1.2 keeps the local path of a sent file or image out of outgoing messages. The helper and its protocol are unchanged (Protocol 16).
Changes
Up/Downrecalled the display text of sent file and image items,[file] <local path>, and Enter sent it as a chat message. Messages now carry their kind, and recall offers only text messages.Ein the bar: the keyboard shortcut started an edit on an own file or image item and put its local path into the composer, where Enter passes it tomessage.edit.Enow follows the Edit button, which is already hidden for those items. The PlainText gate's two ChatPage source hashes are updated for this one-condition change.docs/CURRENT.md, the user guide and the terminal-client stage.Verification
make test, including the terminal client's 110 unit tests. The new recall test fails on v1.1.1 and passes here.tests/chat-input-scroll.shpressesEon an own file item and an own image item in the real ChatPage, then on an own text message as the control, in direct and group chats. It fails on v1.1.1 (E edited an own file item) and passes here.make helper,make archand./tests/no-signal-build.sh../tests/phase2.shand./tests/phase8.sh.qmllint ChatSurface.qml pages/ChatPage.qml Service.qml,omarchy plugin validate .,git diff --checkand shellcheck on all*.sh.Upoffered the last text message on both sides, also after a restart reloaded the history, andEnterdelivered only that text;[file] <local path>onUp; the draft was cleared without sending;