Repository navigation
omaq-connect 1.1.1: cancel incoming transfers, keep transfer lines in view, name the size limit - #62
Merged
Merged
Conversation
:cancelfile now cancels an accepted incoming transfer as well, and the helper confirms it with file.canceled; on a pending offer it declines, like :declinefile. The receiving line names :cancelfile too. Transfer lines stay at the bottom of their pane while the chat scrolls, so PgUp no longer moves them out of view. A file over 8 MiB, the helper's OMAQ_FILE_MAX, is refused before sending with "Files can be at most 8 MiB"; a unit test keeps both limits equal.
The manifest moves to 1.1.1, still Protocol 16. CURRENT.md and the terminal-client stage name 1.1.1 for the transfer fixes: canceling an incoming transfer, transfer lines that stay in view, and the 8 MiB limit before sending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OmaQ 1.1.1 polishes file transfers in the terminal client. The helper and its protocol are unchanged (Protocol 16).
Changes
:cancelfilealso cancels an accepted incoming transfer, and the helper confirms it withfile.canceled. On a pending offer it declines, like:declinefile. The receiving line names:cancelfile, like the sending line.PgUpno longer scrolls them away.OMAQ_FILE_MAX) is refused before sending withFiles can be at most 8 MiB. A unit test keeps the client's limit equal tohelper/file.h.docs/CURRENT.mdand the terminal-client stage.Verification
make test, including the terminal client's 109 unit tests. The three new tests fail on v1.1.0 and pass here.make helper,make archand./tests/no-signal-build.sh../tests/phase2.sh../tests/phase8.sh: its checks pass ("phase8: ok"), but it exits 1. Its cleanup deletes the test homes while the killed test helper still writestox.savethere, andset -eturns that into the exit code. This is unrelated to the client.qmllint ChatSurface.qml pages/ChatPage.qml Service.qml,omarchy plugin validate .,git diff --checkand shellcheck on all*.sh.:cancelfile, and both sides showed the cancellation;PgUpthe transfer lines stayed visible on both sides;